-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Unhandled rejection stack #113614
Log Unhandled rejection stack #113614
Conversation
Pinging @elastic/kibana-core (Team:Core) |
|
||
expect(logger.get('process').warn).toHaveBeenCalledTimes(1); | ||
expect(loggingSystemMock.collect(logger).warn[0][0]).toMatch( | ||
/Detected an unhandled Promise rejection: Error: something went wrong\n.*at Object.<anonymous> \(/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can remove the part after at
to avoid dependency on the serialization format?
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/maps/documents_source/docvalue_fields·js.maps app documents source docvalue_fields should format date fields as epoch_millis when data driven styling is applied to a date fieldStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
* Refactor state types * Log the stack trace of unhandled promise rejections * Revert "Refactor state types" This reverts commit 6a5123a. * Fix types * code review feedback
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Refactor state types * Log the stack trace of unhandled promise rejections * Revert "Refactor state types" This reverts commit 6a5123a. * Fix types * code review feedback Co-authored-by: Rudolf Meijering <[email protected]>
Summary
Print the stack trace of unhandled promise rejections. Related to discussion in #98650
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers