-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Allow rule types to specify custom timeout values #113487
[Alerting] Allow rule types to specify custom timeout values #113487
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I added a couple of comments and curious to your thoughts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a comment about allowlists and some wording suggestions for the docs/README
@@ -179,3 +179,10 @@ For example, `20m`, `24h`, `7d`, `1w`. Default: `60s`. | |||
|
|||
`xpack.alerting.maxEphemeralActionsPerAlert`:: | |||
Sets the number of actions that will be executed ephemerally. To use this, enable ephemeral tasks in task manager first with <<task-manager-settings,`xpack.task_manager.ephemeral_tasks.enabled`>> | |||
|
|||
`xpack.alerting.defaultRuleTaskTimeout`:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to the docker allowlist and also open a cloud PR for this setting?
Co-authored-by: ymao1 <[email protected]>
…#113487) * [Alerting] Allow rule types to specify custom timeout values * fixed tests and docs * - * fixed due to comments * Update x-pack/plugins/alerting/README.md Co-authored-by: ymao1 <[email protected]> * fixed tests and docs * Update plugin.test.ts Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]>
#113957) * [Alerting] Allow rule types to specify custom timeout values * fixed tests and docs * - * fixed due to comments * Update x-pack/plugins/alerting/README.md Co-authored-by: ymao1 <[email protected]> * fixed tests and docs * Update plugin.test.ts Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: ymao1 <[email protected]>
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
Summary
Resolves #111804
In this PR was extended rules registry ability to specify rule task timeout, which could be useful for some rule types which expecting a log running rules.
Could be set in the rule type properties:
Added ability to configure default framework rule task timeout using Kibana config setting:
xpack.alerting.defaultRuleTaskTimeout
Checklist