Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Add deprecation titles #113387

Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Sep 29, 2021

Summary

Closes #113190

Also added i18n to messages.

How to test

  1. Start Kibana on 7.x with these changes applied
  2. Navigate to upgrade assistant and confirm that expected titles are present in the Kibana section (per screenshots)

Screenshots

Screenshot 2021-09-29 at 13 02 55

Screenshot 2021-09-29 at 13 03 02

Screenshot 2021-09-29 at 13 03 12

@jloleysens jloleysens added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Reporting Services v7.16.0 labels Sep 29, 2021
@jloleysens jloleysens requested review from a team as code owners September 29, 2021 11:09
@jloleysens
Copy link
Contributor Author

jloleysens commented Sep 29, 2021

I find deprecations a little bit confusing on this one because I thought the roles deprecation was being registered here:

x-pack/plugins/reporting/server/deprecations/reporting_role.ts

Is there a possibility that we'll have this deprecation listed twice? I see they are performing slightly different checks, but it looks like addressing one should address the other?

[UPDATE]

I see the one instance is listing the number of users that have the deprecated role where the other is listing the deprecated config. Probably worth keeping both as they should both be cleaned up.

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/search/session·ts.apis search search session touched time updates when you poll on an search

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]                 │
[00:00:00]                   └-: apis
[00:00:00]                     └-> "before all" hook in "apis"
[00:00:00]                     └-: search
[00:00:00]                       └-> "before all" hook in "search"
[00:00:03]                       └-: search session
[00:00:03]                         └-> "before all" hook for "should fail to extend a nonexistent session"
[00:00:03]                         └-> should fail to extend a nonexistent session
[00:00:03]                           └-> "before each" hook: global before each for "should fail to extend a nonexistent session"
[00:00:03]                           │ proc [kibana]   log   [16:54:55.683] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:03]                           │ proc [kibana]   statusCode: 404,
[00:00:03]                           │ proc [kibana]   error: 'Not Found',
[00:00:03]                           │ proc [kibana]   message: 'Saved object [search-session/123] not found'
[00:00:03]                           │ proc [kibana] }
[00:00:03]                           └- ✓ pass  (83ms) "apis search search session should fail to extend a nonexistent session"
[00:00:03]                         └-> should sync search ids into not persisted session
[00:00:03]                           └-> "before each" hook: global before each for "should sync search ids into not persisted session"
[00:00:03]                           │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:03]                           │ proc [kibana]   log   [16:54:55.840] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:03]                           │ proc [kibana]   statusCode: 404,
[00:00:03]                           │ proc [kibana]   error: 'Not Found',
[00:00:03]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.035217042362028605] not found'
[00:00:03]                           │ proc [kibana] }
[00:00:03]                           │ debg --- retry.waitForWithTimeout error: expected 200 "OK", got 404 "Not Found"
[00:00:03]                           │ proc [kibana]   log   [16:54:56.411] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:03]                           │ proc [kibana]   statusCode: 404,
[00:00:03]                           │ proc [kibana]   error: 'Not Found',
[00:00:03]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.035217042362028605] not found'
[00:00:03]                           │ proc [kibana] }
[00:00:04]                           │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:00:04]                           │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/koFz7ydUQkCVnVIjK6oWMQ] update_mapping [_doc]
[00:00:04]                           └- ✓ pass  (1.3s) "apis search search session should sync search ids into not persisted session"
[00:00:04]                         └-> should complete session when searches complete
[00:00:04]                           └-> "before each" hook: global before each for "should complete session when searches complete"
[00:00:04]                           │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:04]                           │ debg --- retry.waitForWithTimeout error: expected [] to contain 'FjAwOHJldVg1U0NLM3JHc3pQeHJ6elEbV0xycldwTDhRQ2FSWmJfTk54OER0ZzoyMjk1'
[00:00:05]                           │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:00:08]                           │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/koFz7ydUQkCVnVIjK6oWMQ] update_mapping [_doc]
[00:00:16]                           │ debg Waiting up to 5000ms for searches eventually complete and session gets into the complete state...
[00:00:16]                           └- ✓ pass  (11.6s) "apis search search session should complete session when searches complete"
[00:00:16]                         └-> touched time updates when you poll on an search
[00:00:16]                           └-> "before each" hook: global before each for "touched time updates when you poll on an search"
[00:00:16]                           │ debg Waiting up to 20000ms for search session created...
[00:00:16]                           │ proc [kibana]   log   [16:55:08.616] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:16]                           │ proc [kibana]   statusCode: 404,
[00:00:16]                           │ proc [kibana]   error: 'Not Found',
[00:00:16]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.2294875263780305] not found'
[00:00:16]                           │ proc [kibana] }
[00:00:16]                           │ proc [kibana]   log   [16:55:09.179] [error][dataEnhanced][data_enhanced][plugins] {
[00:00:16]                           │ proc [kibana]   statusCode: 404,
[00:00:16]                           │ proc [kibana]   error: 'Not Found',
[00:00:16]                           │ proc [kibana]   message: 'Saved object [search-session/my-session-0.2294875263780305] not found'
[00:00:16]                           │ proc [kibana] }
[00:00:20]                           └- ✖ fail: apis search search session touched time updates when you poll on an search
[00:00:20]                           │      Error: expected '2021-09-29T16:55:09.597Z' to be below 2021-09-29T16:55:09.597Z
[00:00:20]                           │       at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:00:20]                           │       at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:336:8)
[00:00:20]                           │       at Function.lessThan (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:531:15)
[00:00:20]                           │       at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
[00:00:20]                           │       at runMicrotasks (<anonymous>)
[00:00:20]                           │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:00:20]                           │       at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:00:20]                           │ 
[00:00:20]                           │ 

Stack Trace

Error: expected '2021-09-29T16:55:09.597Z' to be below 2021-09-29T16:55:09.597Z
    at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:336:8)
    at Function.lessThan (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/expect/expect.js:531:15)
    at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/12/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Reviewed the code changes only, as they are minor and only affect the title field of the Reporting deprecation objects.

@jloleysens jloleysens merged commit 9a530b2 into elastic:master Sep 30, 2021
@jloleysens jloleysens deleted the reporting/fix-config-deprecations-titles branch September 30, 2021 08:44
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 30, 2021
* added i18n and titles to config deprecations

* Updated jest test

* Add newline at end of file

* remove unneeded space
jloleysens added a commit that referenced this pull request Sep 30, 2021
* added i18n and titles to config deprecations

* Updated jest test

* Add newline at end of file

* remove unneeded space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporting deprecation needs a title
3 participants