-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Add deprecation titles #113387
[Reporting] Add deprecation titles #113387
Conversation
I find deprecations a little bit confusing on this one because I thought the roles deprecation was being registered here:
Is there a possibility that we'll have this deprecation listed twice? I see they are performing slightly different checks, but it looks like addressing one should address the other? [UPDATE] I see the one instance is listing the number of users that have the deprecated role where the other is listing the deprecated config. Probably worth keeping both as they should both be cleaned up. |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/search/session·ts.apis search search session touched time updates when you poll on an searchStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed the code changes only, as they are minor and only affect the title field of the Reporting deprecation objects.
* added i18n and titles to config deprecations * Updated jest test * Add newline at end of file * remove unneeded space
Summary
Closes #113190
Also added
i18n
to messages.How to test
Screenshots