Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] Migrate indices view to React #113338

Merged
merged 3 commits into from
Sep 29, 2021
Merged

[Stack Monitoring] Migrate indices view to React #113338

merged 3 commits into from
Sep 29, 2021

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Sep 28, 2021

Summary

Closes #113148

Migrates the Indices view to React.

Note that the Angular view used apiUrlFn instead of getPageData in order to populate the page with data. In the React view, we can still use the getPageData function to do this with no ill effects.

@Zacqary Zacqary requested a review from a team as a code owner September 28, 2021 21:55
@Zacqary Zacqary requested review from a team September 28, 2021 21:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes labels Sep 28, 2021
matschaffer
matschaffer approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably okay once CI approves.

The rows per page is broken, I suspect paginating in general is broken.

https://github.com/elastic/kibana/pull/113284/files#diff-11d9ae75fd1e5b55e9d79c648e4c21f5f338a5d117536854f7e2d7058209418aR101 might fix it, but on my pages sort is broken, which works on yours. So could be my fix is in complete.

Either way I think we can fix it in followups.

@Zacqary
Fix lint
4b9beef
@Zacqary
Merge remote-tracking branch 'upstream/master' into 113148-indices-mi…
4f0bc6e 
…gration

# Conflicts:
#	x-pack/plugins/monitoring/public/application/hooks/use_local_storage.ts
#	x-pack/plugins/monitoring/public/application/index.tsx
#	x-pack/plugins/monitoring/public/components/elasticsearch/index.d.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 614 615 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 972.3KB 975.1KB +2.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 8a63be0 into elastic:master Sep 29, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@Zacqary @kibanamachine
[Stack Monitoring] Migrate indices view to React (elastic#113338)
27603e4 
* [Stack Monitoring] Migrate indices view to React

* Fix lint
@kibanamachine kibanamachine mentioned this pull request Sep 29, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 30, 2021
@kibanamachine @Zacqary
[Stack Monitoring] Migrate indices view to React (#113338) (#113485)
6ef73bf 
* [Stack Monitoring] Migrate indices view to React

* Fix lint

Co-authored-by: Zacqary Adam Xeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neptunian neptunian neptunian left review comments

@matschaffer matschaffer matschaffer approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Stack Monitoring] Elasticsearch Indices View Migration from Angular
5 participants
@Zacqary @elasticmachine @kibanamachine @matschaffer @neptunian