Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Wired up the suggestions table to logic #113322

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

JasonStoltz
Copy link
Member

Summary

This PR wires up the static suggestions table on the Curations view to real logic.

latest

To test with suggestions, use the following API endpoint:

curl --location --request POST 'localhost:3002/api/as/v0/engines/national-parks-demo/create_search_relevance_suggestions' \
--header 'Authorization: Basic xxxxx' \
--header 'Content-Type: application/json' \
--data-raw '{
      "query" : "test2",
      "type": "curation",
      "status": "pending",
      "promoted": ["park_grand-teton", "park_hot-springs"],
      "operation": "create"
}'

Closes https://github.com/elastic/app-search-team/issues/1938

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@JasonStoltz JasonStoltz added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 28, 2021
@JasonStoltz JasonStoltz requested a review from a team September 28, 2021 19:38
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1449 1450 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +878.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @byronhulcher

Copy link
Contributor

@byronhulcher byronhulcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JasonStoltz JasonStoltz merged commit 39899f8 into elastic:master Sep 29, 2021
@JasonStoltz JasonStoltz deleted the suggestions-table-2 branch September 29, 2021 19:28
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 29, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants