Remove showClose and onClose options in confirm modal #11321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason they were added is no longer necessary (something for view edit mode which didn’t pan out). It was a point of contention: See elastic#10104 and elastic#10069 (review) for background. Since it’s no longer needed anyway, and this is going to get moved to react anyhow, I’m removing the unused functionality.
w33ble
approved these changes
Apr 19, 2017
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Apr 19, 2017
The reason they were added is no longer necessary (something for view edit mode which didn’t pan out). It was a point of contention: See elastic#10104 and elastic#10069 (review) for background. Since it’s no longer needed anyway, and this is going to get moved to react anyhow, I’m removing the unused functionality.
stacey-gammon
added a commit
that referenced
this pull request
Apr 19, 2017
The reason they were added is no longer necessary (something for view edit mode which didn’t pan out). It was a point of contention: See #10104 and #10069 (review) for background. Since it’s no longer needed anyway, and this is going to get moved to react anyhow, I’m removing the unused functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason they were added is no longer necessary (something for view
edit mode which didn’t pan out). It was a point of contention:
See #10104
and
#10069 (review)
for background.
Since it’s no longer needed anyway, and this is going to get moved to
react anyhow, I’m removing the unused functionality.