Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - re-enable tests after ES fix #113095

Merged
merged 1 commit into from
Sep 27, 2021
Merged

[ML] Functional tests - re-enable tests after ES fix #113095

merged 1 commit into from
Sep 27, 2021

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Sep 27, 2021 •
edited
Loading

Summary

With the Elasticsearch fix elastic/elasticsearch#77801 merged, we can now re-enable the test suites that have been skipped due to the corresponding sort optimization issue.

Closes #112405
Closes #112194
Closes #112174
Closes #104174

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 27, 2021
@pheyos pheyos requested a review from a team as a code owner September 27, 2021 09:01
@pheyos pheyos self-assigned this Sep 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pheyos

walterra
walterra approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 27, 2021
@pheyos pheyos merged commit 149d402 into elastic:master Sep 27, 2021
@pheyos pheyos deleted the re_enable_tests branch September 27, 2021 11:38
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2021
@pheyos @kibanamachine
[ML] Functional tests - re-enable tests after ES fix (elastic#113095)
83856a6 
With the Elasticsearch fix elastic/elasticsearch#77801 merged, we can now re-enable the test suites that have been skipped due to the corresponding sort optimization issue.
@kibanamachine kibanamachine mentioned this pull request Sep 27, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 27, 2021
@kibanamachine @pheyos
[ML] Functional tests - re-enable tests after ES fix (#113095) (#113104)
f819bf4 
With the Elasticsearch fix elastic/elasticsearch#77801 merged, we can now re-enable the test suites that have been skipped due to the corresponding sort optimization issue.

Co-authored-by: Robert Oskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@pheyos pheyos

Labels
auto-backport Deprecated - use backport:version if exact versions are needed :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/anomaly_explorer·ts - machine learning anomaly detection anomaly explorer with farequote based multi metric job renders View By swim lane Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/date_nanos_job·ts - machine learning anomaly detection job on data set with date_nanos time field with count detector and model plot disabled runs the job and displays it correctly in the job list Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/multi_metric_job·ts - machine learning anomaly detection multi metric job creation runs the job and displays it correctly in the job list Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/anomaly_detection/saved_search_job·ts - machine learning anomaly detection saved search with lucene query job creation runs the job and displays it correctly in the job list
5 participants
@pheyos @elasticmachine @kibanamachine @walterra @peteharverson