Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive Migration] xpack..saved_objects_management/spaces_integration #113047

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Sep 23, 2021

Drop the old es archive,
use 2 kbn archives instead,
and the spaces svc.

Should unblock this pr: #112433

@wayneseymour wayneseymour added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 23, 2021
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour wayneseymour marked this pull request as ready for review September 27, 2021 12:44
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the 2 archives can be combined into 1.

@wayneseymour wayneseymour force-pushed the archive-migration/xpack-saved-objects-management-spaces-integration branch from 6b099cf to 8b1cb87 Compare September 29, 2021 19:12
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

1 similar comment
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you just need to remove an used file and if Jenkins still passes LGTM

Drop the old es archive,
use 2 kbn archives instead,
and the spaces svc.
Drop the old es archive,
use the new archive,
and the spaces svc.
@wayneseymour wayneseymour force-pushed the archive-migration/xpack-saved-objects-management-spaces-integration branch from 393deee to fa7c368 Compare October 1, 2021 13:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wayneseymour wayneseymour merged commit 33b501c into master Oct 1, 2021
@wayneseymour wayneseymour deleted the archive-migration/xpack-saved-objects-management-spaces-integration branch October 1, 2021 15:51
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113047

wayneseymour added a commit to wayneseymour/kibana that referenced this pull request Oct 1, 2021
elastic#113047)

# Conflicts:
#	x-pack/test/functional/apps/saved_objects_management/spaces_integration.ts
#	x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/data.json
#	x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json
wayneseymour added a commit that referenced this pull request Oct 1, 2021
…gration (#113047) (#113643)

* [Archive Migration] xpack..saved_objects_management/spaces_integration (#113047)

# Conflicts:
#	x-pack/test/functional/apps/saved_objects_management/spaces_integration.ts
#	x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/data.json
#	x-pack/test/functional/es_archives/saved_objects_management/spaces_integration/mappings.json

* Drop unused symbol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants