Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC][Observability]: test cases for alerts pagination functional tests #112617
[RAC][Observability]: test cases for alerts pagination functional tests #112617
Changes from 16 commits
4216ae5
d0e547f
654632a
5dd6819
e88c5f4
0cf7755
a41b62d
b7c8dac
0e2e9f1
429f438
c59c15f
2f60aad
51e9a93
c14a59e
3cd5672
b19d04c
7c45c7b
6aa828b
0b0bcd5
6f60710
af8275f
8fabfb0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: These properties seem to be sorted by which page element they are using, but it's still a flat list. Would it be helpful to group related properties in an object?
I'm thinking something like:
That would make it faster to scan which properties exist for a particular page element. A middle ground between having many small providers while still helping with some readability.
Not sure what would be done for those that only have function.