[Archive Migration] xpack..reporting-api-integ/reporting-security #112432
Conversation
Found another spot where the es archive for discover is still in use. Use the kbn archive instead.
wayneseymour
added
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
…g-reporting-security
| @@ -42,7 +44,7 @@ export default function ({ getService }: FtrProviderContext) { | |||
|
|
|||
| after('remove index alias', async () => { | |||
| await esArchiver.load('test/functional/fixtures/es_archiver/logstash_functional'); | |||
| await esArchiver.load('test/functional/fixtures/es_archiver/discover'); | |||
| await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover'); | |||
There was a problem hiding this comment.
I think both of these lines should be unload?
Also, I don't understand what the call to cleanupIndexAlias does.
There was a problem hiding this comment.
Well, they were originally .load()'s: https://github.com/elastic/kibana/blob/master/x-pack/test/reporting_api_integration/reporting_and_security/bwc_existing_indexes.ts#L44
As for the kbn archiver, yes...that should be an unload. Great catch.
For cleanupIndexAlias, its a Higher Order Function. When it's called, it adds and index alias, and then it returns a fn, that when called, removes the same index alias...that it created.
It's first applied here:
this is where it creates.
Later on, it's called in the after method, cleaning up what it created, that index.
Anyway, so Ill change the kbn archiver call to be an unload. Same for the logstash call boss?
There was a problem hiding this comment.
Yes, please unload logstash_functional as well.
In the parent index file there's 10 tests. 4 of those load logstash_functional. So another option would be to split those 10 tests into 2 describes and manage the load/unload of logstash_functional in the before/after there for those 4 tests. That would save loading it 3 times. But you don't need to do that on this PR unless you want to.
There was a problem hiding this comment.
Yeah I'd love to that right after this is merged.
|
@tsullivan thanks mate! |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…astic#112432) * [Archive Migration] xpack..reporting-api-integ/reporting-security Found another spot where the es archive for discover is still in use. Use the kbn archive instead. * Switch to unload, per cr. * unload logstash Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…12432) (#112620) * [Archive Migration] xpack..reporting-api-integ/reporting-security Found another spot where the es archive for discover is still in use. Use the kbn archive instead. * Switch to unload, per cr. * unload logstash Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tre <[email protected]>
spalger
deleted the
archive-migration/xpack-reporting-api-integ-reporting-security
branch
Found another spot where the es archive
for discover is still in use.
Use the kbn archive instead.
Helps with: #102552
Partially unblocks: #110445