-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Make Formula functional tests less flaky #112428
Conversation
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
Can we backport to 7.14+? Here's a recent failure: |
@elasticmachine merge upstream |
I see no harm in that. What do you think @stratoula @flash1293 ? |
Yes it is fine. For functional tests fixes it is safe to backport them in previous versions |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Changed labels to enable backports to 7.14+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, not sure if it will help avoiding flakiness completely, but definitely will not harm anything!
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Marco Liberati <[email protected]>
Summary
Fixes (again) #102183
Adding some waiting time after the typing fixed the flaky behaviour - the editor schedules a text replacement as async task and sometimes it takes a bit longer than usual.
Here I've ran the
lens formula
suite with 100 agents: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1902/Checklist
Delete any items that are not applicable to this PR.