-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] Beats Overview view migration #112377
Conversation
@elasticmachine merge upstream |
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @matschaffer |
* Wire up a stub beats overview page * Filling in some bits * Figured out this todo already * Fix importa and product name * Wire up BeatsOverview component * Set breadcrumbs * Add "beats" part to breadcrumbs * Remove unused vars copied from ES overview * Use passed data rather than outer scope * Fixing basic type checks * Fix breadcrumb type issues Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* Wire up a stub beats overview page * Filling in some bits * Figured out this todo already * Fix importa and product name * Wire up BeatsOverview component * Set breadcrumbs * Add "beats" part to breadcrumbs * Remove unused vars copied from ES overview * Use passed data rather than outer scope * Fixing basic type checks * Fix breadcrumb type issues Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Mat Schaffer <[email protected]>
Summary
This PR is part of #111757
Latest react view
7.14 angular view (for comparison)
This has the same zoom/url tracking issues observed in #111941 - to be fixed in #112063