Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Beats Overview view migration #112377

Merged
merged 14 commits into from
Sep 27, 2021

Conversation

matschaffer
Copy link
Contributor

@matschaffer matschaffer commented Sep 16, 2021

Summary

This PR is part of #111757

Latest react view

Screen Shot 2021-09-21 at 15 05 31

7.14 angular view (for comparison)

Screen Shot 2021-09-21 at 15 05 45

This has the same zoom/url tracking issues observed in #111941 - to be fixed in #112063

@matschaffer matschaffer added v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Epic: Stack Monitoring de-angularization labels Sep 16, 2021
@matschaffer matschaffer self-assigned this Sep 16, 2021
@matschaffer
Copy link
Contributor Author

@elasticmachine merge upstream

@matschaffer matschaffer marked this pull request as ready for review September 21, 2021 06:13
@matschaffer matschaffer requested a review from a team as a code owner September 21, 2021 06:13
@matschaffer matschaffer requested review from a team September 21, 2021 06:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@matschaffer
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matschaffer matschaffer enabled auto-merge (squash) September 27, 2021 01:39
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 603 605 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 942.6KB 946.6KB +4.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

@matschaffer matschaffer merged commit 970394b into elastic:master Sep 27, 2021
@matschaffer matschaffer deleted the react-beats-views branch September 27, 2021 03:41
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2021
* Wire up a stub beats overview page

* Filling in some bits

* Figured out this todo already

* Fix importa and product name

* Wire up BeatsOverview component

* Set breadcrumbs

* Add "beats" part to breadcrumbs

* Remove unused vars copied from ES overview

* Use passed data rather than outer scope

* Fixing basic type checks

* Fix breadcrumb type issues

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 27, 2021
* Wire up a stub beats overview page

* Filling in some bits

* Figured out this todo already

* Fix importa and product name

* Wire up BeatsOverview component

* Set breadcrumbs

* Add "beats" part to breadcrumbs

* Remove unused vars copied from ES overview

* Use passed data rather than outer scope

* Fixing basic type checks

* Fix breadcrumb type issues

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Mat Schaffer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants