Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Retain Viewmode State in Session #112302

Merged

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Sep 15, 2021

Fixes #91191 - Flaky Test Runner - (100 Successful runs!)
Fixes #108920

Summary

This PR allows dashboard to store state from viewMode into the session. This means that changes to dashboard filters and query made by users in view mode will be retained over browser refreshes and app navigations.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

…nd query will be kept over reloads and navigations
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.14.2 v7.15.1 labels Sep 15, 2021
@ThomThomson ThomThomson changed the title Made dashboard retain viewmode state in session. This means filters a… [Dashboard] Retain Viewmode State in Session Sep 15, 2021
@ThomThomson ThomThomson marked this pull request as ready for review September 16, 2021 16:50
@ThomThomson ThomThomson requested a review from a team as a code owner September 16, 2021 16:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 135.3KB 135.3KB -6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ThomThomson ThomThomson merged commit 5408a3e into elastic:master Sep 21, 2021
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Sep 21, 2021
* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Sep 21, 2021
* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Sep 21, 2021
* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations
ThomThomson added a commit that referenced this pull request Sep 21, 2021
* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 23, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

ThomThomson added a commit that referenced this pull request Sep 27, 2021
ThomThomson added a commit that referenced this pull request Sep 27, 2021
* [Dashboard] Retain Viewmode State in Session (#112302)

* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations

* clear filters to avoid maps but #64861

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.14.3 v7.15.1 v7.16.0 v8.0.0
Projects
None yet
4 participants