-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Retain Viewmode State in Session #112302
[Dashboard] Retain Viewmode State in Session #112302
Conversation
…nd query will be kept over reloads and navigations
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations
* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations
* Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
* [Dashboard] Retain Viewmode State in Session (#112302) * Made dashboard retain viewmode state in session. This means filters and query will be kept over reloads and navigations * clear filters to avoid maps but #64861 Co-authored-by: Kibana Machine <[email protected]>
Fixes #91191 - Flaky Test Runner - (100 Successful runs!)
Fixes #108920
Summary
This PR allows dashboard to store state from viewMode into the session. This means that changes to dashboard filters and query made by users in view mode will be retained over browser refreshes and app navigations.
Checklist
Delete any items that are not applicable to this PR.
For maintainers