-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Change terminology: "index pattern" becomes "data view" #112021
[APM] Change terminology: "index pattern" becomes "data view" #112021
Conversation
@@ -11,7 +11,7 @@ elasticsearch.hosts: http://localhost:9201 | |||
elasticsearch.username: 'kibana_system_user' | |||
elasticsearch.password: 'changeme' | |||
|
|||
# APM index pattern | |||
# APM data view | |||
apm_oss.indexPattern: apm-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sqren Should I also change the config key to dataView?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been deprecated so you can just leave that: #111133
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. weren't you going to remove the entire e2e
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will, but in another PR.
const staticIndexPatternRoute = createApmServerRoute({ | ||
endpoint: 'POST /api/apm/index_pattern/static', | ||
const staticDataViewRoute = createApmServerRoute({ | ||
endpoint: 'POST /api/apm/data_view/static', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sqren Should I change the APIs to data_view
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for Uptime changes LGTM,
WFG !!
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/apm-ui (Team:apm) |
@shahzad31 There're still a few components that use |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
fyi @mattkime |
New PR pointing to the feature branch #112166 |
closes #101206
Renames all texts, files and function from
index pattern
todata view