Default to named ui/public: a to m #11200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
changed the title
stacey-gammon
force-pushed
the
default-to-named-ui-public-a-to-m
branch
2 times, most recently
from
b72f688 to
6512541
Compare
stacey-gammon
force-pushed
the
default-to-named-ui-public-a-to-m
branch
2 times, most recently
from
f8e1322 to
178cc23
Compare
|
@stacey-gammon, Please resolve the conflicts |
stacey-gammon
force-pushed
the
default-to-named-ui-public-a-to-m
branch
from
178cc23 to
0631836
Compare
|
@BigFunger, done! |
stacey-gammon
requested review from
lukasolson
and removed request for
BigFunger
|
@lukasolson You are the winning choice of reviewer (you can thank @BigFunger 😸 ). If you can't get to it today or tomorrow, lmk and I'll continue my search. P.S. as reviewer, since the changes are really too great to peruse over individually, I think it's sufficient to check it out locally, explore the product a bit, and keep an eye out in the console for 'module undefined' errors. |
stacey-gammon
force-pushed
the
default-to-named-ui-public-a-to-m
branch
from
0631836 to
c560141
Compare
lukasolson
approved these changes
Apr 14, 2017
| import getPercentileValue from './percentiles_get_value'; | ||
| import { AggTypesMetricsMetricAggTypeProvider } from 'ui/agg_types/metrics/metric_agg_type'; | ||
| import { AggTypesMetricsGetResponseAggConfigClassProvider } from 'ui/agg_types/metrics/get_response_agg_config_class'; | ||
| import{ getPercentileValue } from './percentiles_get_value'; |
There was a problem hiding this comment.
Not a big deal, but missing a space here.
| @@ -1,7 +1,7 @@ | |||
| import sinon from 'auto-release-sinon'; | |||
| import expect from 'expect.js'; | |||
| import ngMock from 'ng_mock'; | |||
| import FilterBarLibGenerateMappingChainProvider from 'ui/filter_bar/lib/generate_mapping_chain'; | |||
| import { GenerateMappingChainProvider } from 'ui/filter_bar/lib/generate_mapping_chain'; | |||
There was a problem hiding this comment.
Just curious, why remove the FilterBarLib prefix here but not below in FilterBarLibMapAndFlattenFiltersProvider?
There was a problem hiding this comment.
Hmm, not sure why I did it that way, but does look like I kept the prefixes on all the others, so will switch back to keeping the prefix here!
stacey-gammon
force-pushed
the
default-to-named-ui-public-a-to-m
branch
from
c560141 to
8a6663b
Compare
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Apr 16, 2017
* Convert remaining export default's in ui/public * Chunk 2 * Part 3 * Part 4 * Part 5 Note: Must check in https://github.com/elastic/x-pack-kibana/pull/938 first * Part 6 * Part 6 * Part 8 * Part 9 * address code review comments
stacey-gammon
added a commit
that referenced
this pull request
Apr 17, 2017
* Convert remaining export default's in ui/public * Chunk 2 * Part 3 * Part 4 * Part 5 Note: Must check in https://github.com/elastic/x-pack-kibana/pull/938 first * Part 6 * Part 6 * Part 8 * Part 9 * address code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10981. Converting rest of ui/public to using named exports only. Default exports may still be around where they are used prolifically, or in x-pack.
Background: #8641