Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Removing trailing semicolor and scrollbar for empty pie chart visualization #111971

Merged
merged 2 commits into from
Sep 14, 2021
Merged

[Lens] Removing trailing semicolor and scrollbar for empty pie chart visualization #111971

merged 2 commits into from
Sep 14, 2021

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Sep 13, 2021

Summary

Fixes #111747

Before:

Screenshot 2021-09-13 at 17 21 35

After:

Screenshot 2021-09-13 at 17 20 05

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 13, 2021
@dej611 dej611 requested a review from a team as a code owner September 13, 2021 15:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

flash1293
flash1293 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. It would be cool to have a linting rule for this

@dej611
Copy link
Contributor Author

dej611 commented Sep 14, 2021

@flash1293 I can add a functional Lens test for all the visualizations.

@flash1293
Copy link
Contributor

@dej611 I don't think it's necessary tbh. If it happens again one more time, let's add automation :)

@dej611
Copy link
Contributor Author

dej611 commented Sep 14, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB -4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit e37cacb into elastic:master Sep 14, 2021
@dej611 dej611 deleted the fix/111747 branch September 14, 2021 12:03
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 14, 2021
@dej611 @kibanamachine
[Lens] Removing trailing semicolor and scrollbar for empty pie chart …
3ec3732 
…visualization (elastic#111971)

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Sep 14, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 14, 2021
@kibanamachine @dej611
[Lens] Removing trailing semicolor and scrollbar for empty pie chart …
c298c32 
…visualization (#111971) (#112082)

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Marco Liberati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Semicolon floating on empty chart workspace for no data
5 participants
@dej611 @elasticmachine @flash1293 @kibanamachine @mbondyra