Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove executionLog to reduce memory consumption #111911

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Remove executionLog to reduce memory consumption #111911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce86dcf
Remove executionLog to reduce memory consumption
rudolf Sep 10, 2021
31abf46
Merge branch 'master' into migrations-memory
kibanamachine Sep 13, 2021
052bf5f
Merge branch 'master' into migrations-memory
kibanamachine Sep 14, 2021
993f9c0
Debug log entire migration state on every transition
rudolf Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core/server/logging/appenders/file/file_appender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@ export class FileAppender implements DisposableAppender {
return resolve();
}

this.outputStream.end(() => {
this.outputStream = undefined;
const outputStream = this.outputStream;
this.outputStream = undefined;

outputStream.end(() => {
Comment on lines +68 to +71
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just

this.outputStream.end(() => {   
    resolve();
});
this.outputStream = undefined;

?

I think the handler will never be executed synchronously?

resolve();
});
});
Expand Down
Loading