Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC] [Observability] Add functional tests covering the alert workflow status #111788
[RAC] [Observability] Add functional tests covering the alert workflow status #111788
Changes from 1 commit
b7ab54b
e3ca668
426849f
bf8707e
8b5fa43
ad77056
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Is it more more common to say "filter by"? This confused my brain for a moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In "filter by" I'm always wondering whether it means to include or exclude. But I can probably try harder to find an unambiguous description with more natural grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to make the test case names clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW for me, by always means include. Similar to how "sort by" works, you sort by what you desire, and you filter by what you desire. But the "predicate" nature of this makes it harder I agree.
But I would imagine it likes this: filter by $PREDICATE, where if the predicate is true you include it, so "open" vs "not open"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Similar here, this test name is still a bit unclear with regards to what "can be set". Maybe the word alert is needed here as well?
"an alert can be set to "acknowledged" using the row action menu"?
I don't think this needs to be changed, more looking to discuss patterns.