Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fix incorrect number of alerts shows under External alert trend #111746

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Sep 9, 2021

issue: #111679

Summary

During a previous fix, I broke the trend graph for External alerts. The reason is that I started counting the total of events based on the bucket. But every kind of MatrixHistogramType has a different aggregation name. eventActionGroup was wrongly hardcoded inside useMatrixHistogram. After this change, buckets should be returned for every type of MatrixHistogram.

132640542-440cd073-2c02-4277-8226-d2fd7c2ead8b.mp4

Checklist

@machadoum machadoum added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Sep 9, 2021
@machadoum machadoum requested a review from a team as a code owner September 9, 2021 15:48
@machadoum machadoum self-assigned this Sep 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
securitySolution 1285 1292 +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +36.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 207.7KB 208.4KB +778.0B
Unknown metric groups

API count

id before after diff
securitySolution 1338 1345 +7

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 10, 2021
kibanamachine added a commit that referenced this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants