Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topN popover for case view #111514

Merged
merged 2 commits into from
Sep 8, 2021
Merged

fix topN popover for case view #111514

merged 2 commits into from
Sep 8, 2021

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Sep 8, 2021

Summary

issue: topN in flyout on caseView has some styling issue.

before:
Screenshot 2021-09-08 at 15 05 47

after fix:
Screenshot 2021-09-08 at 11 47 16
Screenshot 2021-09-08 at 11 44 05
Screenshot 2021-09-08 at 11 43 39
Screenshot 2021-09-08 at 14 00 00

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0 v8.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. bug Fixes for quality problems that affect the customer experience labels Sep 8, 2021
@angorayc angorayc marked this pull request as ready for review September 8, 2021 13:21
@angorayc angorayc requested a review from a team as a code owner September 8, 2021 13:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB -277.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 22acf4f into elastic:master Sep 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
* fix topN popover for case view

* unit tests
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
* fix topN popover for case view

* unit tests
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 8, 2021
* fix topN popover for case view

* unit tests

Co-authored-by: Angela Chuang <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 8, 2021
* fix topN popover for case view

* unit tests

Co-authored-by: Angela Chuang <[email protected]>
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
* fix topN popover for case view

* unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants