Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix indices permission for functional test #111284

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

kertal
Copy link
Member

@kertal kertal commented Sep 6, 2021

Summary

Fixes permission for functional testing newline handling in cloud testing

fixes #105317

Checklist

@kertal kertal added Feature:Discover Discover Application v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v7.16.0 v7.14.2 Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 6, 2021
@kertal kertal self-assigned this Sep 6, 2021
@kertal
Copy link
Member Author

kertal commented Sep 7, 2021

@elasticmachine merge upstream

@kertal kertal requested a review from liza-mae September 7, 2021 18:56
@kertal
Copy link
Member Author

kertal commented Sep 7, 2021

dear @liza-mae, I can't test this, but it should work, can you test it?

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

@kertal kertal added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 8, 2021
@kertal kertal marked this pull request as ready for review September 8, 2021 05:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x
7.14

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 8, 2021
kibanamachine added a commit that referenced this pull request Sep 8, 2021
kibanamachine added a commit that referenced this pull request Sep 8, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 8, 2021
…-link-to-kibana-app

* 'master' of github.com:elastic/kibana: (61 commits)
  [Logs UI] Fix alert previews for thresholds of `0` (elastic#111150)
  [Archive Migration][Partial] discover apps-discover (elastic#110437)
  [APM] Set start date of APM ML job to -4 weeks (elastic#111375)
  [ML] APM Latency Correlations: Code consolidation. (elastic#110790)
  [Discover] Fix indices permission for multiline test (elastic#111284)
  [Detection Rules] Add 7.15 rules (elastic#111464)
  [Security Solution][Endpoint][Host Isolation] Hide isolate host option in alert details rather than disabling (elastic#111064)
  React version of angular license view (elastic#111317)
  [APM] Fix link in readme (elastic#111362)
  [Security Solution] add agent field to generator (elastic#111428)
  [Dashboard] Retain Tags on Quicksave (elastic#111015)
  Reorder App Search ingestion methods (elastic#111361)
  Port performance docs to new docs system. (elastic#111063)
  [Security Solution][RAC] Fixes updatedAt loading bug (elastic#111010)
  [sample data] update web log geo.src field to match country code of geo.coordinates (elastic#110885)
  [Security solution] [Endpoint] Fix bad artifact migration (elastic#111294)
  Fix copy typo. (elastic#111203)
  [build] Remove empty optimize directory (elastic#111393)
  [Maps] fix term join not updating when editing right field (elastic#111030)
  [Fleet] Set default settings in component template instead of the index template (elastic#111197)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/management/__snapshots__/report_listing.test.tsx.snap
#	x-pack/plugins/reporting/public/management/report_listing.test.tsx
@spalger spalger deleted the kertal-pr-2021-09-06-dsc-fix-cloud-functional branch September 8, 2021 15:37
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v7.14.2 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
4 participants