[APM] Updates failed transaction correlations help #111222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
v7.15.1
v7.16.0
v8.0.0
apm:correlations
release_note:skip
sorenlouv
reviewed
Sep 6, 2021
| @@ -36,7 +36,7 @@ export function FailedTransactionsCorrelationsHelpPopover() { | |||
| <p> | |||
| <FormattedMessage | |||
| id="xpack.apm.correlations.failedTransactions.helpPopover.basicExplanation" | |||
| defaultMessage="Correlations help you discover which attributes are contributing to failed transactions. Transactions are considered a failure when it returns a status code >= 5xx." | |||
| defaultMessage="Correlations help you discover which attributes are most influential in distinguishing between transaction failures and successes. Transactions are considered a failure when their `event.outcome` value is `failure`." | |||
There was a problem hiding this comment.
By default transactions with status code 5xx are marked as failed. So it might make sense to still mention this somehow (or maybe this belongs in the docs?)
There was a problem hiding this comment.
Thanks! I've added that example to the docs in #111219
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
sorenlouv
approved these changes
Sep 8, 2021
sorenlouv
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 8, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 8, 2021
kibanamachine
added a commit
that referenced
this pull request
Sep 8, 2021
Co-authored-by: Lisa Cawley <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 8, 2021
Co-authored-by: Lisa Cawley <[email protected]>
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #108441
This PR updates the help for the failed transactions correlations, such that it mentions the event.outcome field rather than the status code. It also aims to clarify that we look at the set of successful transactions and compare it to the set of failed transactions.
Screenshot