Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Rename index pattern to data view #111137

Merged
merged 8 commits into from
Sep 7, 2021
Merged

[Alerting] Rename index pattern to data view #111137

merged 8 commits into from
Sep 7, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Sep 3, 2021 •
edited
Loading

Resolves #100871

Note that this PR merges into the index_patterns_to_data_views_user_content_feature_branch feature branch, as per instructions in the meta-issue

@ymao1 ymao1 self-assigned this Sep 3, 2021
@ymao1 ymao1 added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Sep 3, 2021
@ymao1 ymao1 marked this pull request as ready for review September 3, 2021 14:37
@ymao1 ymao1 requested review from a team as code owners September 3, 2021 14:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@ymao1 ymao1 linked an issue Sep 3, 2021 that may be closed by this pull request
Alerting: Index patterns => data views - update user facing copy #100871
Closed
kindsun
kindsun approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geo portions lgtm. Thanks!

  • code review

@chrisronline
Copy link
Contributor

I found a couple more places here:

chrisronline
chrisronline approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 7, 2021

@elasticmachine merge upstream

YulNaumenko
YulNaumenko approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 7, 2021

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 7, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit dcbb5be into elastic:index_patterns_to_data_views_user_content_feature_branch Sep 7, 2021
This was referenced Sep 7, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@kindsun kindsun kindsun approved these changes

@chrisronline chrisronline chrisronline approved these changes

Assignees

@ymao1 ymao1

Labels
Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alerting: Index patterns => data views - update user facing copy
6 participants
@ymao1 @elasticmachine @chrisronline @kibanamachine @kindsun @YulNaumenko