Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detection Rules] Changes 'activated' text on rule details page #111044

Merged
merged 3 commits into from
Sep 3, 2021
Merged

[Security Solution][Detection Rules] Changes 'activated' text on rule details page #111044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11c4100
changes text
dplumlee Sep 2, 2021
36da282
updates i18n
dplumlee Sep 2, 2021
3033b2b
Merge branch 'master' into rule-details-text-change
kibanamachine Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...lugins/security_solution/public/detections/pages/detection_engine/rules/details/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ const RuleDetailsPageComponent: React.FC<DetectionEngineComponentProps> = ({
enabled={isExistingRule && (rule?.enabled ?? false)}
onChange={handleOnChangeEnabledRule}
/>
<EuiFlexItem>{i18n.ACTIVATED_RULE}</EuiFlexItem>
<EuiFlexItem>{i18n.ACTIVATE_RULE}</EuiFlexItem>
</EuiFlexGroup>
</EuiToolTip>
</EuiFlexItem>
Expand Down
6 changes: 3 additions & 3 deletions .../security_solution/public/detections/pages/detection_engine/rules/details/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ export const EXPERIMENTAL = i18n.translate(
}
);

export const ACTIVATED_RULE = i18n.translate(
'xpack.securitySolution.detectionEngine.ruleDetails.activatedRuleLabel',
export const ACTIVATE_RULE = i18n.translate(
'xpack.securitySolution.detectionEngine.ruleDetails.activateRuleLabel',
{
defaultMessage: 'Activated',
defaultMessage: 'Activate',
}
);

Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20849,7 +20849,6 @@
"xpack.securitySolution.detectionEngine.ruleDescription.mlJobStoppedDescription": "停止",
"xpack.securitySolution.detectionEngine.ruleDescription.thresholdResultsAggregatedByDescription": "結果集約条件",
"xpack.securitySolution.detectionEngine.ruleDescription.thresholdResultsAllDescription": "すべての結果",
"xpack.securitySolution.detectionEngine.ruleDetails.activatedRuleLabel": "有効化",
"xpack.securitySolution.detectionEngine.ruleDetails.deletedRule": "削除されたルール",
"xpack.securitySolution.detectionEngine.ruleDetails.errorCalloutTitle": "ルール失敗",
"xpack.securitySolution.detectionEngine.ruleDetails.exceptionsTab": "例外",
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21318,7 +21318,6 @@
"xpack.securitySolution.detectionEngine.ruleDescription.mlJobStoppedDescription": "已停止",
"xpack.securitySolution.detectionEngine.ruleDescription.thresholdResultsAggregatedByDescription": "结果聚合依据",
"xpack.securitySolution.detectionEngine.ruleDescription.thresholdResultsAllDescription": "所有结果",
"xpack.securitySolution.detectionEngine.ruleDetails.activatedRuleLabel": "已激活",
"xpack.securitySolution.detectionEngine.ruleDetails.deletedRule": "已删除规则",
"xpack.securitySolution.detectionEngine.ruleDetails.errorCalloutTitle": "规则错误位置",
"xpack.securitySolution.detectionEngine.ruleDetails.exceptionsTab": "例外",
Expand Down