Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Removed any from public #110993

Merged
merged 6 commits into from
Sep 7, 2021

Conversation

jloleysens
Copy link
Contributor

Summary

Per the title, removed any anys from TS files in Reporting public. Additionally, ran "Organize imports" command on each file to tidy the import ordering.

@jloleysens jloleysens added chore (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Sep 2, 2021
@jloleysens jloleysens requested review from a team as code owners September 2, 2021 14:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending green build

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
reporting 13 12 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 68.3KB 68.3KB -48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 4a8ad1c into elastic:master Sep 7, 2021
@jloleysens jloleysens deleted the reporting/remove-public-anys branch September 7, 2021 15:47
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 7, 2021
* removed anys and ran TS organize imports

* updated jest snapshots

* fix import paths for non-type imports

Co-authored-by: Kibana Machine <[email protected]>
jloleysens added a commit that referenced this pull request Sep 7, 2021
* removed anys and ran TS organize imports

* updated jest snapshots

* fix import paths for non-type imports

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
* removed anys and ran TS organize imports

* updated jest snapshots

* fix import paths for non-type imports

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants