Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Migrationsv2: limit batch sizes to migrations.batchSizeBytes (= 100mb by default) (#109540) #110967

Merged
merged 3 commits into from
Sep 3, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Sep 2, 2021

Backports the following commits to 7.x:

… by default) (elastic#109540)

* Fix logging for existing integration test

* First stab at limiting batches to batchSizeBytes

* Fix tests

* Fix batch size calculation, NDJSON needs to be terminated by an empty line

* Integration tests

* Fix type failures

* rename migration integration tests and log files to be consistent & more descriptive

* Review feedback

* Remove duplication of fatal error reasons

* migrations.maxBatchSizeBytes to docker environment vars

* docs for migrations.maxBatchSizeBytes
# Conflicts:
#	src/core/server/saved_objects/migrationsv2/integration_tests/7_13_0_unknown_types.test.ts
#	src/core/server/saved_objects/migrationsv2/integration_tests/migration_from_v1.test.ts
@rudolf rudolf added the backport label Sep 2, 2021
@rudolf rudolf enabled auto-merge (squash) September 2, 2021 12:03
@rudolf
Copy link
Contributor Author

rudolf commented Sep 3, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit 93dfcc6 into elastic:7.x Sep 3, 2021
@rudolf rudolf deleted the backport/7.x/pr-109540 branch May 16, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants