Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Unskip ILM migration tests #110813

Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Sep 1, 2021

Summary

Closes: #110483

It looks like after elastic/elasticsearch#74212 was merged the .reporting-* indices have been flagged as restricted which affected our ability to check user privileges.

Adding a new flag allow_restricted_indices to the _has_privileges call fixes our ability to check this.

@jloleysens jloleysens added chore (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes labels Sep 1, 2021
@jloleysens jloleysens requested a review from tsullivan September 1, 2021 14:36
@jloleysens jloleysens requested review from a team as code owners September 1, 2021 14:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens added the backport:skip This commit does not require backporting label Sep 2, 2021
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm thrilled that you figured this one out -- I was stumped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing ES Promotion: Reporting APIs ILM policy migration APIs detects when no migration is needed
4 participants