-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Archive Migration] xpack...packaging #110451
Conversation
Use x-pack/test/functional/fixtures/kbn_archiver/packaging.json instead of x-pack/test/functional/es_archives/packaging **TODO: Drop x-pack/test/functional/es_archives/packaging**
7a0846e
to
766ead1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM. Just need to resolve other test failure. Maybe merge upstream.
Roger that, and thanks!
…On Wed, Sep 1, 2021 at 3:24 PM Lee Drengenberg ***@***.***> wrote:
***@***.**** approved this pull request.
Code review LGTM. Just need to resolve other test failure. Maybe merge
upstream.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#110451 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFCBQ3FX3POVYXTMI6OP3DT7YZRVANCNFSM5DBTMDUA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
*Tre' Seymour*
Senior Software Engineer
Kibana QA - JavaScript Engineer in Test
https://www.elastic.co/
|
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elastic/kibana-app-services may I have a review here pretty pls? |
@elastic/kibana-reporting-services may I have a review here pretty pls? |
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
merge conflict between base and head |
…tion/xpack-packaging
…c/kibana into archive-migration/xpack-packaging
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
@vadimkibana Thanks!!! |
Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tre <[email protected]>
Use x-pack/test/functional/fixtures/kbn_archiver/packaging.json
instead of x-pack/test/functional/es_archives/packaging