Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive Migration] xpack...packaging #110451

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Aug 30, 2021

Use x-pack/test/functional/fixtures/kbn_archiver/packaging.json
instead of x-pack/test/functional/es_archives/packaging

@wayneseymour wayneseymour added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0 labels Aug 30, 2021
Use x-pack/test/functional/fixtures/kbn_archiver/packaging.json
instead of x-pack/test/functional/es_archives/packaging

**TODO: Drop x-pack/test/functional/es_archives/packaging**
@wayneseymour wayneseymour force-pushed the archive-migration/xpack-packaging branch from 7a0846e to 766ead1 Compare September 1, 2021 09:11
@wayneseymour wayneseymour marked this pull request as ready for review September 1, 2021 09:12
@wayneseymour wayneseymour requested review from a team as code owners September 1, 2021 09:12
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM. Just need to resolve other test failure. Maybe merge upstream.

@wayneseymour
Copy link
Member Author

wayneseymour commented Sep 1, 2021 via email

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@elastic/kibana-app-services may I have a review here pretty pls?

@wayneseymour
Copy link
Member Author

@elastic/kibana-reporting-services may I have a review here pretty pls?

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@wayneseymour wayneseymour merged commit e250c27 into master Sep 15, 2021
@wayneseymour wayneseymour deleted the archive-migration/xpack-packaging branch September 15, 2021 13:10
@wayneseymour
Copy link
Member Author

@vadimkibana Thanks!!!

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 15, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants