Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Visualize] Wizard rename Index pattern to Data view #110251

Merged
merged 2 commits into from
Sep 29, 2021
Merged

[Visualize] Wizard rename Index pattern to Data view #110251

merged 2 commits into from
Sep 29, 2021

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Aug 26, 2021 •
edited by stratoula
Loading

Part of #105199

Summary

Renamed index patterns to data views in Visualize Wizard UI.

image

Checklist

For maintainers

@DianaDerevyankina DianaDerevyankina added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 labels Aug 26, 2021
@DianaDerevyankina DianaDerevyankina self-assigned this Aug 26, 2021
@stratoula
Copy link
Contributor

@dziyanadzeraviankina let's resolve the conflicts. I think we can omit the changes in the translation files. It is a very small change so I think we can merge it

@DianaDerevyankina
Merge branch 'master' into wizard-index-pattern-to-data-view
00361c3 
# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@stratoula stratoula marked this pull request as ready for review September 29, 2021 07:01
@stratoula stratoula requested a review from a team as a code owner September 29, 2021 07:01
@stratoula stratoula added backport:skip This commit does not require backporting and removed v7.16.0 labels Sep 29, 2021
stratoula
stratoula approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked it locally in Chrome.
This is safe to merge it, I don't expect a lot of changes in this file.
This should be merged only for v8! No need to backport

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 72.6KB 72.6KB -8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

@DianaDerevyankina DianaDerevyankina merged commit a8084b7 into elastic:master Sep 29, 2021
DianaDerevyankina added a commit that referenced this pull request Oct 7, 2021
@DianaDerevyankina
Revert "[Visualize] Wizard rename Index pattern to Data view (#110251)"
23889da 
This reverts commit a8084b7.
@DianaDerevyankina DianaDerevyankina mentioned this pull request Oct 7, 2021
Merged
DianaDerevyankina added a commit that referenced this pull request Oct 7, 2021
@DianaDerevyankina
Revert "[Visualize] Wizard rename Index pattern to Data view (#110251)…
87e6fb4 
…" (#114276)

This reverts commit a8084b7.
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this pull request Oct 11, 2021
@DianaDerevyankina
[Visualize] Wizard rename Index pattern to Data view (elastic#110251)
bc2357d
DianaDerevyankina added a commit that referenced this pull request Oct 11, 2021
@DianaDerevyankina
[Visualize] Wizard rename Index pattern to Data view (#110251) (#114443)
629647e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@VladLasitsa VladLasitsa Awaiting requested review from VladLasitsa

@alexwizp alexwizp Awaiting requested review from alexwizp

@dej611 dej611 Awaiting requested review from dej611

@mbondyra mbondyra Awaiting requested review from mbondyra

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
backport:skip This commit does not require backporting Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DianaDerevyankina @stratoula @kibanamachine