Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix upgrade link in Fleet policy table #110228

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

kpollich
Copy link
Member

Summary

Fix "Upgrade Integration" link in Fleet -> Agent Policies -> Package Policy table.

Fixes #110195

Screen Recording

Kapture 2021-08-26 at 09 17 22

@kpollich kpollich added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 26, 2021
@kpollich kpollich self-assigned this Aug 26, 2021
@kpollich kpollich requested a review from a team as a code owner August 26, 2021 13:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 798.8KB 798.8KB -39.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 74f3b76 into elastic:master Aug 27, 2021
@kpollich kpollich deleted the 110195-fix-upgrade-link branch August 27, 2021 12:09
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 27, 2021
* Fix upgrade link in Fleet policy table

* Ensure upgrade page displays as upgrade even without from prop
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 27, 2021
* Fix upgrade link in Fleet policy table

* Ensure upgrade page displays as upgrade even without from prop
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 27, 2021
* Fix upgrade link in Fleet policy table

* Ensure upgrade page displays as upgrade even without from prop

Co-authored-by: Kyle Pollich <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 27, 2021
* Fix upgrade link in Fleet policy table

* Ensure upgrade page displays as upgrade even without from prop

Co-authored-by: Kyle Pollich <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 30, 2021
…eporting-to-v2

* 'master' of github.com:elastic/kibana: (120 commits)
  [Lens] should register "suffix" field formatter in setup lifecycle (elastic#110218)
  skip flaky suite (elastic#98463)
  skip flaky suite (elastic#108633)
  [Data Table] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98903)
  fixes failing tests (elastic#110436)
  [TSVB] Remove deprecated `IFieldType` (elastic#110404)
  [Lens] Remove deprecated `IFieldType` (elastic#109825)
  [Vega] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99023)
  [Visualizations] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#99031)
  [TSVB] Expensive queries are causing unnecessary load and delays on Elasticsearch (elastic#98914)
  Don't add split part of UI if we have one series (elastic#109483)
  [Discover] Migrate angular routing to react router (elastic#107042)
  [Security Solution][Endpoint][Event Filters] Fixes missing spacers between event filters cards (elastic#110282)
  [ML] Data Grid: Fix alignment of sorting arrow when histogram charts are enabled (elastic#110053)
  [canvas] Fix image argument form issues (elastic#109767)
  Fix asset in Pitch template (elastic#109742)
  chore(NA): moving @kbn/securitysolution-list-api to babel transpiler (elastic#110265)
  chore(NA): moving @kbn/securitysolution-list-constants to babel transpiler (elastic#110269)
  [Fleet] Fix upgrade link in Fleet policy table (elastic#110228)
  [ML] APM Latency Correlations: Fix empty state (elastic#109813)
  ...

# Conflicts:
#	src/plugins/data/common/query/timefilter/types.ts
@amolnater-qasource
Copy link

Hi @EricDavisX
We are validating this PR in lieu of reported issue at #110195
We have revalidated this on 7.15.0 Snapshot and found it fixed now.

Observations:

  • Upgrade package policy button navigates user to Upgrade Integration page.

Build details:
Build: 43832
Commit: b7ad04c

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: "Upgrade package policy" button navigates user to Edit Integration page.
5 participants