Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copy references of 'deprecation issues' to 'deprecation warnings'. #109963

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Change copy references of 'deprecation issues' to 'deprecation warnings'. #109963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...s/upgrade_assistant/__jest__/client_integration/es_deprecations/deprecations_list.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ describe('Deprecations table', () => {

expect(exists('noDeprecationsRow')).toBe(true);
expect(find('noDeprecationsRow').text()).toContain(
'No Elasticsearch deprecation issues found'
'No Elasticsearch deprecation warnings found'
);
});
});
Expand Down
2 changes: 1 addition & 1 deletion ...upgrade_assistant/public/application/components/es_deprecations/es_deprecations_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const i18nTexts = {
noDeprecationsMessage: i18n.translate(
'xpack.upgradeAssistant.esDeprecations.table.noDeprecationsMessage',
{
defaultMessage: 'No Elasticsearch deprecation issues found',
defaultMessage: 'No Elasticsearch deprecation warnings found',
}
),
typeFilterLabel: i18n.translate('xpack.upgradeAssistant.esDeprecations.table.typeFilterLabel', {
Expand Down
2 changes: 1 addition & 1 deletion ...gins/upgrade_assistant/public/application/components/overview/backup_step/backup_step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const i18nTexts = {
}),

backupStepDescription: i18n.translate('xpack.upgradeAssistant.overview.backupStepDescription', {
defaultMessage: 'Back up your data before addressing any deprecation issues.',
defaultMessage: 'Back up your data before addressing any deprecation warnings.',
}),
};

Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/upgrade_assistant/server/routes/status.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe('Status API', () => {
expect(resp.payload).toEqual({
readyForUpgrade: false,
details:
'You have 1 Elasticsearch deprecation issues and 1 Kibana deprecation issues that must be resolved before upgrading.',
'You have 1 Elasticsearch deprecation warnings and 1 Kibana deprecation warnings that must be resolved before upgrading.',
});
});

Expand All @@ -97,7 +97,7 @@ describe('Status API', () => {
expect(resp.status).toEqual(200);
expect(resp.payload).toEqual({
readyForUpgrade: true,
details: 'All deprecation issues have been resolved.',
details: 'All deprecation warnings have been resolved.',
});
});

Expand Down
4 changes: 2 additions & 2 deletions x-pack/plugins/upgrade_assistant/server/routes/status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,14 @@ export function registerUpgradeStatusRoute({ router }: RouteDependencies) {
return i18n.translate(
'xpack.upgradeAssistant.status.allDeprecationsResolvedMessage',
{
defaultMessage: 'All deprecation issues have been resolved.',
defaultMessage: 'All deprecation warnings have been resolved.',
}
);
}

return i18n.translate('xpack.upgradeAssistant.status.deprecationsUnresolvedMessage', {
defaultMessage:
'You have {esTotalCriticalDeps} Elasticsearch deprecation issues and {kibanaTotalCriticalDeps} Kibana deprecation issues that must be resolved before upgrading.',
'You have {esTotalCriticalDeps} Elasticsearch deprecation warnings and {kibanaTotalCriticalDeps} Kibana deprecation warnings that must be resolved before upgrading.',
values: { esTotalCriticalDeps, kibanaTotalCriticalDeps },
});
};
Expand Down