Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snapshot and Restore locator. #109886

Merged
merged 2 commits into from
Aug 25, 2021
Merged

Add Snapshot and Restore locator. #109886

merged 2 commits into from
Aug 25, 2021

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Aug 24, 2021 •
edited
Loading

This forwardports changes introduced to 7.x via #109543

This blocks #109834

@cjcenizal cjcenizal added backported v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI v7.16.0 labels Aug 24, 2021
@cjcenizal cjcenizal requested a review from a team as a code owner August 24, 2021 17:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@cjcenizal cjcenizal mentioned this pull request Aug 24, 2021
Merged
3 tasks
@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
snapshotRestore 180 181 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
snapshotRestore 453.5KB 450.0KB -3.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
snapshotRestore 41.4KB 47.3KB +5.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code was already reviewed on 7.x. Verified changes were ported correctly.

@cjcenizal cjcenizal merged commit b300a1d into elastic:master Aug 25, 2021
@cjcenizal cjcenizal deleted the forwardport/8.0/snapshot-and-restore-locator branch August 25, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees
No one assigned
Labels
backported Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjcenizal @elasticmachine @kibanamachine @alisonelizabeth