Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] [o11y] add permission in alerts table from kibana privilege/consumer #109759

Merged
merged 8 commits into from
Aug 25, 2021
Merged

[RAC] [o11y] add permission in alerts table from kibana privilege/consumer #109759

merged 8 commits into from
Aug 25, 2021

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Aug 24, 2021

Summary

#109109

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience release_note:enhancement v8.0.0 impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Threat Hunting Security Solution Threat Hunting Team auto-backport Deprecated - use backport:version if exact versions are needed Theme: rac label obsolete v7.15.0 v7.16.0 labels Aug 24, 2021
@XavierM XavierM requested a review from a team as a code owner August 24, 2021 02:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

yctercero
yctercero approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

jonathan-buttner
jonathan-buttner reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth adding a few tests for the permissions and selection logic?

x-pack/plugins/observability/public/hooks/use_alert_permission.ts Outdated Show resolved Hide resolved
x-pack/plugins/timelines/public/components/t_grid/body/index.tsx Outdated Show resolved Hide resolved
semd
semd approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhurley14
Copy link
Contributor

In general when fixing bugs it's beneficial to add a sanity-check test to ensure we are covering the bug with these changes and to ensure future changes do not re-introduce this bug.

jonathan-buttner
jonathan-buttner approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally. Looks good.

@XavierM XavierM enabled auto-merge (squash) August 24, 2021 16:44
@weltenwort weltenwort mentioned this pull request Aug 24, 2021
Closed
52 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
securitySolution 1282 1284 +2
timelines 840 842 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 568.0KB 568.4KB +337.0B
timelines 439.7KB 442.0KB +2.3KB
total +2.6KB
Unknown metric groups

API count

id before after diff
securitySolution 1335 1337 +2
timelines 960 962 +2
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 6a1a38b into elastic:master Aug 25, 2021
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@XavierM @kibanamachine
[RAC] [o11y] add permission in alerts table from kibana privilege/con…
bce014a 
…sumer (elastic#109759)

* add alert permission in o11y

* review I

* review II

* fix selection all when checkbox disabled

* fix selected on bulk actions
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
@XavierM @kibanamachine
[RAC] [o11y] add permission in alerts table from kibana privilege/con…
f49434a 
…sumer (elastic#109759)

* add alert permission in o11y

* review I

* review II

* fix selection all when checkbox disabled

* fix selected on bulk actions
@kibanamachine kibanamachine mentioned this pull request Aug 25, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @XavierM
[RAC] [o11y] add permission in alerts table from kibana privilege/con…
9f2fe19 
…sumer (#109759) (#109988)

* add alert permission in o11y

* review I

* review II

* fix selection all when checkbox disabled

* fix selected on bulk actions

Co-authored-by: Xavier Mouligneau <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 25, 2021
@kibanamachine @XavierM
[RAC] [o11y] add permission in alerts table from kibana privilege/con…
e126836 
…sumer (#109759) (#109989)

* add alert permission in o11y

* review I

* review II

* fix selection all when checkbox disabled

* fix selected on bulk actions

Co-authored-by: Xavier Mouligneau <[email protected]>
@mgiota mgiota mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

@semd semd semd approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

@weltenwort weltenwort Awaiting requested review from weltenwort

@machadoum machadoum Awaiting requested review from machadoum

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:enhancement Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@XavierM @elasticmachine @dhurley14 @kibanamachine @yctercero @semd @jonathan-buttner