Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection rules link for memory and behaviour protections cards #109591

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix detection rules link for memory and behaviour protections cards #109591

merged 1 commit into from
Aug 23, 2021

Conversation

academo
Copy link
Contributor

@academo academo commented Aug 23, 2021

Summary

Fixes #109397

@academo academo requested a review from a team as a code owner August 23, 2021 07:58
@academo academo requested review from pzl and ashokaditya August 23, 2021 07:58
@academo academo added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 v7.16.0 labels Aug 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

@academo academo mentioned this pull request Aug 23, 2021
Closed
ashokaditya
ashokaditya approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Simple enough. We should add a test for this. If not in this PR then in a new one.

@academo academo requested review from paul-tavares and removed request for pzl August 23, 2021 08:59
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB -38.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

paul-tavares
paul-tavares approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

reminder: you need to also add the v8.0.0 label to this PR

@academo academo added the v8.0.0 label Aug 23, 2021
@academo academo merged commit 60a74e8 into elastic:master Aug 23, 2021
@academo academo deleted the fix/memory-behaviour-detection-rules-link-109397 branch August 23, 2021 13:15
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@academo @kibanamachine
Fix detection rules link for memory and behaviour protections cards (e…
88f0b04 
…lastic#109591)
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
@academo @kibanamachine
Fix detection rules link for memory and behaviour protections cards (e…
9182d2f 
…lastic#109591)
@kibanamachine kibanamachine mentioned this pull request Aug 23, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.15
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 23, 2021
@kibanamachine @academo
Fix detection rules link for memory and behaviour protections cards (#…
7425cd2 
…109591) (#109647)

Co-authored-by: Esteban Beltran <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 24, 2021
@kibanamachine @academo
Fix detection rules link for memory and behaviour protections cards (#…
799bffb 
…109591) (#109648)

Co-authored-by: Esteban Beltran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-tavares paul-tavares paul-tavares approved these changes

@ashokaditya ashokaditya ashokaditya approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@academo @elasticmachine @kibanamachine @ashokaditya @paul-tavares