Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[index pattern management] index pattern => data view for user facing content #109577

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Aug 22, 2021

Summary

'Index pattern' => 'Data view' for user facing copy in index pattern management.

@mattkime mattkime changed the title index pattern => data view for user facing content [index pattern management] index pattern => data view for user facing content Aug 22, 2021
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes Team:AppServices v8.0.0 labels Aug 22, 2021
@mattkime mattkime marked this pull request as ready for review August 23, 2021 02:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -97,7 +97,9 @@ export const IndexPatternTable = ({
const columns = [
{
field: 'title',
name: 'Pattern',
name: i18n.translate('indexPatternManagement.dataViewTable.nameColumn', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattkime mattkime merged commit d5faaf7 into elastic:index_patterns_to_data_views_user_content_feature_branch Aug 24, 2021
mattkime added a commit that referenced this pull request Oct 20, 2021
…109821)

* [index pattern management] index pattern => data view for user facing content (#109577)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants