[RAC] [Security Solution] Hides the Show top <field> action in chart legends
#109566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t legends ## Summary Fixes <elastic#108910> , which allowed users to launch a new `Top <field>` popover from an existing popover, to infinity (and beyond) The `Show top <field>` action is now hidden in the `Top <field>` popover's chart legend, and also: - In the legend items of charts throughout the Security Solution (e.g. on the `Overview` page, and in the `Trend` chart on the `Alerts` page) - For items in the `Count` aggregation table on the `Alerts` page ## Screenshots ### Before (Top `signal.rule.name` popover)  _Above: It was possible to launch another `Top <field>` popover from the legend of an existing popover_ ### After (Top `signal.rule.name` popover)  _Above: It is no longer possible to launch another `Top <field>` popover from the legend of an existing popover_ ### Before (Chart legends)  _Above: It was possible to launch a `Top <field>` popover from chart legends_ ### After (Chart legends)  _Above: It is no longer possible to launch a `Top <field>` popover from chart legends_ ### Before (`Count` items)  _Above: It was possible to launch a `Top <field>` popover from `Count` items_ ### After (`Count` items)  _Above: It is no longer possible to launch a `Top <field>` popover from `Count` items_ cc @mdefazio
andrew-goldstein
added
bug
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
@elasticmachine merge upstream |
angorayc
approved these changes
Aug 23, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2021
…t legends (elastic#109566) ## Summary Fixes <elastic#108910> , which allowed users to launch a new `Top <field>` popover from an existing popover, to infinity (and beyond) The `Show top <field>` action is now hidden in the `Top <field>` popover's chart legend, and also: - In the legend items of charts throughout the Security Solution (e.g. on the `Overview` page, and in the `Trend` chart on the `Alerts` page) - For items in the `Count` aggregation table on the `Alerts` page ## Screenshots ### Before (Top `signal.rule.name` popover)  _Above: It was possible to launch another `Top <field>` popover from the legend of an existing popover_ ### After (Top `signal.rule.name` popover)  _Above: It is no longer possible to launch another `Top <field>` popover from the legend of an existing popover_ ### Before (Chart legends)  _Above: It was possible to launch a `Top <field>` popover from chart legends_ ### After (Chart legends)  _Above: It is no longer possible to launch a `Top <field>` popover from chart legends_ ### Before (`Count` items)  _Above: It was possible to launch a `Top <field>` popover from `Count` items_ ### After (`Count` items)  _Above: It is no longer possible to launch a `Top <field>` popover from `Count` items_ cc @mdefazio
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2021
…t legends (elastic#109566) ## Summary Fixes <elastic#108910> , which allowed users to launch a new `Top <field>` popover from an existing popover, to infinity (and beyond) The `Show top <field>` action is now hidden in the `Top <field>` popover's chart legend, and also: - In the legend items of charts throughout the Security Solution (e.g. on the `Overview` page, and in the `Trend` chart on the `Alerts` page) - For items in the `Count` aggregation table on the `Alerts` page ## Screenshots ### Before (Top `signal.rule.name` popover)  _Above: It was possible to launch another `Top <field>` popover from the legend of an existing popover_ ### After (Top `signal.rule.name` popover)  _Above: It is no longer possible to launch another `Top <field>` popover from the legend of an existing popover_ ### Before (Chart legends)  _Above: It was possible to launch a `Top <field>` popover from chart legends_ ### After (Chart legends)  _Above: It is no longer possible to launch a `Top <field>` popover from chart legends_ ### Before (`Count` items)  _Above: It was possible to launch a `Top <field>` popover from `Count` items_ ### After (`Count` items)  _Above: It is no longer possible to launch a `Top <field>` popover from `Count` items_ cc @mdefazio
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2021
…t legends (#109566) (#109657) ## Summary Fixes <#108910> , which allowed users to launch a new `Top <field>` popover from an existing popover, to infinity (and beyond) The `Show top <field>` action is now hidden in the `Top <field>` popover's chart legend, and also: - In the legend items of charts throughout the Security Solution (e.g. on the `Overview` page, and in the `Trend` chart on the `Alerts` page) - For items in the `Count` aggregation table on the `Alerts` page ## Screenshots ### Before (Top `signal.rule.name` popover)  _Above: It was possible to launch another `Top <field>` popover from the legend of an existing popover_ ### After (Top `signal.rule.name` popover)  _Above: It is no longer possible to launch another `Top <field>` popover from the legend of an existing popover_ ### Before (Chart legends)  _Above: It was possible to launch a `Top <field>` popover from chart legends_ ### After (Chart legends)  _Above: It is no longer possible to launch a `Top <field>` popover from chart legends_ ### Before (`Count` items)  _Above: It was possible to launch a `Top <field>` popover from `Count` items_ ### After (`Count` items)  _Above: It is no longer possible to launch a `Top <field>` popover from `Count` items_ cc @mdefazio Co-authored-by: Andrew Goldstein <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Aug 24, 2021
…t legends (#109566) (#109658) ## Summary Fixes <#108910> , which allowed users to launch a new `Top <field>` popover from an existing popover, to infinity (and beyond) The `Show top <field>` action is now hidden in the `Top <field>` popover's chart legend, and also: - In the legend items of charts throughout the Security Solution (e.g. on the `Overview` page, and in the `Trend` chart on the `Alerts` page) - For items in the `Count` aggregation table on the `Alerts` page ## Screenshots ### Before (Top `signal.rule.name` popover)  _Above: It was possible to launch another `Top <field>` popover from the legend of an existing popover_ ### After (Top `signal.rule.name` popover)  _Above: It is no longer possible to launch another `Top <field>` popover from the legend of an existing popover_ ### Before (Chart legends)  _Above: It was possible to launch a `Top <field>` popover from chart legends_ ### After (Chart legends)  _Above: It is no longer possible to launch a `Top <field>` popover from chart legends_ ### Before (`Count` items)  _Above: It was possible to launch a `Top <field>` popover from `Count` items_ ### After (`Count` items)  _Above: It is no longer possible to launch a `Top <field>` popover from `Count` items_ cc @mdefazio Co-authored-by: Andrew Goldstein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #108910 , which allowed users to launch a new
Top <field>popover from an existing popover, to infinity (and beyond)The
Show top <field>action is now hidden in theTop <field>popover's chart legend, and also:Overviewpage, and in theTrendchart on theAlertspage)Countaggregation table on theAlertspageScreenshots
Before (Top
signal.rule.namepopover)Above: It was possible to launch another
Top <field>popover from the legend of an existing popoverAfter (Top
signal.rule.namepopover)Above: It is no longer possible to launch another
Top <field>popover from the legend of an existing popoverBefore (Chart legends)
Above: It was possible to launch a
Top <field>popover from chart legendsAfter (Chart legends)
Above: It is no longer possible to launch a
Top <field>popover from chart legendsBefore (
Countitems)Above: It was possible to launch a
Top <field>popover fromCountitemsAfter (
Countitems)Above: It is no longer possible to launch a
Top <field>popover fromCountitemscc @mdefazio