-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] Skip failing Cypress test detection_alerts/acknowledged.spec.ts #109532
Merged
banderror
merged 1 commit into
elastic:master
from
banderror:skip-failing-cypress-test-acknowledged.spec.ts
Aug 23, 2021
Merged
[Security Solution][Detections] Skip failing Cypress test detection_alerts/acknowledged.spec.ts #109532
banderror
merged 1 commit into
elastic:master
from
banderror:skip-failing-cypress-test-acknowledged.spec.ts
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.15.0
v7.16.0
labels
Aug 20, 2021
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
dplumlee
approved these changes
Aug 20, 2021
The test has been fixed, see #109533 (review) |
banderror
force-pushed
the
skip-failing-cypress-test-acknowledged.spec.ts
branch
from
August 23, 2021 08:54
ca297aa
to
95608bc
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @banderror |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2021
…lerts/acknowledged.spec.ts (elastic#109532) ## Summary I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time: https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658 The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected". I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well. Skipping for now as it's blocking a critical fix for 7.15: elastic#109276
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 23, 2021
…lerts/acknowledged.spec.ts (elastic#109532) ## Summary I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time: https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658 The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected". I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well. Skipping for now as it's blocking a critical fix for 7.15: elastic#109276
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2021
…lerts/acknowledged.spec.ts (#109532) (#109622) ## Summary I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time: https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658 The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected". I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well. Skipping for now as it's blocking a critical fix for 7.15: #109276 Co-authored-by: Georgii Gorbachev <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Aug 23, 2021
…lerts/acknowledged.spec.ts (#109532) (#109623) ## Summary I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time: https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658 The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected". I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well. Skipping for now as it's blocking a critical fix for 7.15: #109276 Co-authored-by: Georgii Gorbachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detections and Resp
Security Detection Response Team
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v7.15.0
v7.16.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time:
https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658
The test is
detection_alerts/acknowledged.spec.ts
"Mark one alert as acknowledged when more than one open alerts are selected".I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well.
Skipping for now as it's blocking a critical fix for 7.15: #109276