Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detections] Skip failing Cypress test detection_alerts/acknowledged.spec.ts #109532

Conversation

banderror
Copy link
Contributor

Summary

I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time:

https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658

The test is detection_alerts/acknowledged.spec.ts "Mark one alert as acknowledged when more than one open alerts are selected".

I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well.

Skipping for now as it's blocking a critical fix for 7.15: #109276

@banderror banderror added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 labels Aug 20, 2021
@banderror banderror requested a review from dplumlee August 20, 2021 17:57
@banderror banderror self-assigned this Aug 20, 2021
@banderror banderror requested a review from a team as a code owner August 20, 2021 17:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror
Copy link
Contributor Author

The test has been fixed, see #109533 (review)
The affected PR (#109276) is now green.
This skip is not needed anymore.

@banderror banderror closed this Aug 21, 2021
@banderror banderror deleted the skip-failing-cypress-test-acknowledged.spec.ts branch August 21, 2021 01:38
@banderror banderror restored the skip-failing-cypress-test-acknowledged.spec.ts branch August 23, 2021 08:52
@banderror banderror reopened this Aug 23, 2021
@banderror banderror force-pushed the skip-failing-cypress-test-acknowledged.spec.ts branch from ca297aa to 95608bc Compare August 23, 2021 08:54
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #147450 succeeded ca297aabd651a276326f9846666b3fb4d9819b6b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @banderror

@banderror banderror merged commit f9aa9de into elastic:master Aug 23, 2021
@banderror banderror deleted the skip-failing-cypress-test-acknowledged.spec.ts branch August 23, 2021 11:19
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
…lerts/acknowledged.spec.ts (elastic#109532)

## Summary

I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time:

https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658

The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected".

I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well.

Skipping for now as it's blocking a critical fix for 7.15: elastic#109276
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 23, 2021
…lerts/acknowledged.spec.ts (elastic#109532)

## Summary

I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time:

https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658

The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected".

I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well.

Skipping for now as it's blocking a critical fix for 7.15: elastic#109276
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.15
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 23, 2021
…lerts/acknowledged.spec.ts (#109532) (#109622)

## Summary

I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time:

https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658

The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected".

I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well.

Skipping for now as it's blocking a critical fix for 7.15: #109276

Co-authored-by: Georgii Gorbachev <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 23, 2021
…lerts/acknowledged.spec.ts (#109532) (#109623)

## Summary

I’ve been re-running CI for my PR multiple times, getting failed Cypress tests every time:

https://github.com/elastic/kibana/pull/109276/checks?check_run_id=3382731658

The test is `detection_alerts/acknowledged.spec.ts` "Mark one alert as acknowledged when more than one open alerts are selected".

I’m getting the same failure also on a fresh master branch locally, so it seems like the test is broken there as well.

Skipping for now as it's blocking a critical fix for 7.15: #109276

Co-authored-by: Georgii Gorbachev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants