[Cases] Fix add Lens markdown plugin UX #109178
Conversation
patrykkopycinski
added
Feature:Cases
There was a problem hiding this comment.
Changes in designs LGTM. Thanks! (Design changes issue #19021)
|
Hey, ran into an issue testing. I made my own visualization with lots and lots of changes. when i hit save and return i got this: |
There was a problem hiding this comment.
Works like a dream! Great work here @patrykkopycinski
I would like to see tests for use_lens_button_toggle.ts, doesn't have to be in this PR but. please definitely follow up on it! thanks!! LGTM 🚀
|
@elasticmachine merge upstream |
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
| @@ -10,7 +10,7 @@ import { schema, TypeOf } from '@kbn/config-schema'; | |||
| export const ConfigSchema = schema.object({ | |||
| enabled: schema.boolean({ defaultValue: true }), | |||
| markdownPlugins: schema.object({ | |||
| lens: schema.boolean({ defaultValue: false }), | |||
| lens: schema.boolean({ defaultValue: true }), | |||
There was a problem hiding this comment.
Just wanted to double check that we're intentionally turning this feature on by default?
Co-authored-by: Patryk Kopyciński <[email protected]>
# Conflicts: # package.json
KOTungseth
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
Summary
Follow up to #96703
Design followup issue: #109121