Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bringing cypress tests back #109129

Merged
merged 12 commits into from
Aug 19, 2021
Merged

Bringing cypress tests back #109129

merged 12 commits into from
Aug 19, 2021

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Aug 18, 2021 •
edited
Loading

Summary

In this PR we are unskipping most of the skipped Cypress test:

Threat Hunting

  • 'Creates a new case with timeline and opens the timeline' test
    • The test has been fixed deleting the assertions that checks the action button since that button does not exist.
  • Attach alerts to a case tests
    • The tests have been fixed forcing the click when trying to open the context menu.
  • Navigation tests
    • Have been unskipped without any fix.
  • Data provider tests
    • Data provider tests related with drag and drop have been deleted since that functionality is not valid anymore.
  • Local storage test
    • Local storage test has been fixed changing the way we are doing the deletion of the column.

Detections

@MadameSheema MadameSheema mentioned this pull request Aug 19, 2021
Closed
@MadameSheema
Copy link
Member Author

@elasticmachine merge upstream

@MadameSheema MadameSheema self-assigned this Aug 19, 2021
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detections and Resp Security Detection Response Team Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 19, 2021
@MadameSheema MadameSheema marked this pull request as ready for review August 19, 2021 12:56
@MadameSheema MadameSheema requested a review from a team as a code owner August 19, 2021 12:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd
Copy link
Contributor

semd commented Aug 19, 2021

Filter browser test LGTM 🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

FrankHassanabad
FrankHassanabad reviewed Aug 19, 2021
View reviewed changes
x-pack/plugins/security_solution/cypress/integration/exceptions/from_alert.spec.ts
@@ -64,7 +64,7 @@ describe('From alert', () => {
esArchiverUnload('auditbeat_for_exceptions2');
});

// TODO: Looks like the signal is missing some fields. Need to update to make sure it shows up
// TODO: Unskip the test when `https://github.com/elastic/kibana/issues/108244` it is fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the references

FrankHassanabad
FrankHassanabad reviewed Aug 19, 2021
View reviewed changes
x-pack/plugins/security_solution/cypress/integration/exceptions/from_rule.spec.ts
@@ -62,7 +62,7 @@ describe('From rule', () => {
esArchiverUnload('auditbeat_for_exceptions2');
});

// TODO: Looks like the signal is missing some fields. Need to update to make sure it shows up
// TODO: Unskip the test when `https://github.com/elastic/kibana/issues/108244` it is fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the references

FrankHassanabad
FrankHassanabad approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • Looked through the code to see the unskips and good comments about issues and when to unskip things.

@MadameSheema MadameSheema merged commit 91910db into elastic:master Aug 19, 2021
@MadameSheema MadameSheema mentioned this pull request Aug 19, 2021
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Aug 19, 2021
@MadameSheema @kibanamachine
Bringing cypress tests back (elastic#109129)
6cfc479 
* fixes threshold cypress tests

* add ticket command

* fixes threshold cypress tests

* add ticket command

* fixes 'Creates a new case with timeline and opens the timeline' test

* unskips navigation tests

* removes 'sets correct classes when the user starts dragging a host, but is not hovering over the data providers' test since we are not supporting drag and drop on timeline

* removes drag and drop related tests from 'data_providers.spec.ts'

* modifies todo on skipped exceptions tests to add more clarity

* fixes 'attach' to case and local storage test

Co-authored-by: Kibana Machine <[email protected]>
@MadameSheema MadameSheema mentioned this pull request Aug 19, 2021
Merged
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Aug 19, 2021
@MadameSheema @kibanamachine
Bringing cypress tests back (elastic#109129)
253b690 
* fixes threshold cypress tests

* add ticket command

* fixes threshold cypress tests

* add ticket command

* fixes 'Creates a new case with timeline and opens the timeline' test

* unskips navigation tests

* removes 'sets correct classes when the user starts dragging a host, but is not hovering over the data providers' test since we are not supporting drag and drop on timeline

* removes drag and drop related tests from 'data_providers.spec.ts'

* modifies todo on skipped exceptions tests to add more clarity

* fixes 'attach' to case and local storage test

Co-authored-by: Kibana Machine <[email protected]>
MadameSheema added a commit that referenced this pull request Aug 20, 2021
@MadameSheema @kibanamachine
Bringing cypress tests back (#109129) (#109303)
72b0858 
* fixes threshold cypress tests

* add ticket command

* fixes threshold cypress tests

* add ticket command

* fixes 'Creates a new case with timeline and opens the timeline' test

* unskips navigation tests

* removes 'sets correct classes when the user starts dragging a host, but is not hovering over the data providers' test since we are not supporting drag and drop on timeline

* removes drag and drop related tests from 'data_providers.spec.ts'

* modifies todo on skipped exceptions tests to add more clarity

* fixes 'attach' to case and local storage test

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
MadameSheema added a commit that referenced this pull request Aug 20, 2021
@MadameSheema @kibanamachine
Bringing cypress tests back (#109129) (#109305)
786b603 
* fixes threshold cypress tests

* add ticket command

* fixes threshold cypress tests

* add ticket command

* fixes 'Creates a new case with timeline and opens the timeline' test

* unskips navigation tests

* removes 'sets correct classes when the user starts dragging a host, but is not hovering over the data providers' test since we are not supporting drag and drop on timeline

* removes drag and drop related tests from 'data_providers.spec.ts'

* modifies todo on skipped exceptions tests to add more clarity

* fixes 'attach' to case and local storage test

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@michaelolo24
Copy link
Contributor

Thanks @MadameSheema!!

@michaelolo24 michaelolo24 mentioned this pull request Aug 24, 2021
Closed
48 tasks
@MadameSheema MadameSheema deleted the bringing-cypress-tests-back branch May 16, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@michaelolo24 michaelolo24 Awaiting requested review from michaelolo24

@peluja1012 peluja1012 Awaiting requested review from peluja1012

@spong spong Awaiting requested review from spong

@XavierM XavierM Awaiting requested review from XavierM

Assignees

@MadameSheema MadameSheema

Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MadameSheema @elasticmachine @semd @kibanamachine @michaelolo24 @FrankHassanabad