[APM] Hash-based links into APM app don't work #108777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
cauemarcondes
commented
Aug 16, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dgieselaar
reviewed
Aug 19, 2021
Comment on lines
+56
to
+61
| defaults: { | ||
| query: { | ||
| rangeFrom: 'now-15m', | ||
| rangeTo: 'now', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Yes, the ranges are not required when we call this link, andor it's not provided we should add use the default instead
dgieselaar
approved these changes
Aug 19, 2021
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2021
* fixing navigation issues * addressing PR comments
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 19, 2021
* fixing navigation issues * addressing PR comments
kibanamachine
added a commit
that referenced
this pull request
Aug 20, 2021
* fixing navigation issues * addressing PR comments Co-authored-by: Cauê Marcondes <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Aug 20, 2021
* fixing navigation issues * addressing PR comments Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #108539
Uptime navigation with hash.
hash.navigation.mov
Link-to trace id with hash
https://user-images.githubusercontent.com/55978943/129623950-d6aa70f0-1379-4d9a-834e-6ce89c537087.mov