[RAC] [Observability] [Security Solution] Use correct url to management app for observability cases, use normalized ids #108775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ized ids in timelines
kqualters-elastic
changed the title
kqualters-elastic
added
8.0.0
Feature:Observability RAC
Feature:RAC
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
| @@ -52,13 +51,14 @@ const AddToCaseActionComponent: React.FC<AddToCaseActionProps> = ({ | |||
| } = useAddToCase({ event, useInsertTimeline, casePermissions, appId, onClose }); | |||
|
|
|||
| const getAllCasesSelectorModalProps = useMemo(() => { | |||
| const { ruleId, ruleName } = normalizedEventFields(event); | |||
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
48 tasks
| const ruleId = event && event.data.find(({ field }) => field === ALERT_RULE_ID); | ||
| const ruleUuid = event && event.data.find(({ field }) => field === ALERT_RULE_UUID); | ||
| const ruleName = event && event.data.find(({ field }) => field === ALERT_RULE_NAME); | ||
| const ruleIdValue = ruleId && ruleId.value && ruleId.value[0]; |
There was a problem hiding this comment.
is it possible value could have a length of 0? perhaps consider :
Suggested change
| const ruleIdValue = ruleId && ruleId.value && ruleId.value[0]; | |
| const ruleIdValue = getOr('', 'value[0]', ruleId); |
There was a problem hiding this comment.
It shouldn't as far as I know, if it ever blows up I'll come back to this 🤣
stephmilovic
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
LGTM! only thing was that value length question. manual testing went smoothly.
thanks @kqualters-elastic 🚀 🎸
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 17, 2021
…nt app for observability cases, use normalized ids (elastic#108775) * Use correct url to management app for observability cases, use normalized ids in timelines * Update failing test * Load alert details data to render flyout in case detail view
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 17, 2021
…nt app for observability cases, use normalized ids (#108775) (#108958) * Use correct url to management app for observability cases, use normalized ids in timelines * Update failing test * Load alert details data to render flyout in case detail view Co-authored-by: Kevin Qualters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pr adds the link to rules for cases in the observability solution, which was preventing alerts from being shown as comments in the case detail view. Also adds the alert flyout to the case detail view, to display the flyout when clicking the detail button. Also uses normalized rule ids and names across observability and security solution for rule names and ids.