Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty tag validation to cases #108699

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add empty tag validation to cases #108699

merged 1 commit into from
Aug 16, 2021

Conversation

machadoum
Copy link
Member

issue: #91821

Summary

Screenshot 2021-08-16 at 15 38 35
Screenshot 2021-08-16 at 15 38 22

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 8.0.0 labels Aug 16, 2021
@machadoum machadoum requested a review from semd August 16, 2021 13:46
@machadoum machadoum self-assigned this Aug 16, 2021
@machadoum machadoum requested a review from a team as a code owner August 16, 2021 13:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@machadoum machadoum added the release_note:skip Skip the PR/issue when compiling release notes label Aug 16, 2021
semd
semd approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@machadoum machadoum enabled auto-merge (squash) August 16, 2021 13:53
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 579.7KB 580.6KB +941.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 131.9KB 132.1KB +245.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit e2c7313 into elastic:master Aug 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 16, 2021
@machadoum @kibanamachine
Add empty tag validation to cases (elastic#108699)
e7e3f80
@kibanamachine kibanamachine mentioned this pull request Aug 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 16, 2021
@kibanamachine @machadoum
Add empty tag validation to cases (#108699) (#108728)
348b55d 
Co-authored-by: Pablo Machado <[email protected]>
@lukasolson lukasolson added v8.0.0 and removed 8.0.0 labels Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semd semd semd approved these changes

Assignees

@machadoum machadoum

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machadoum @elasticmachine @kibanamachine @semd @lukasolson