[5.x] Introduce tests for add new visualization link (#10785) #10869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5.x intake is still failing at the moment due to linting issues. I'm trying to dig into it now, though I'll be sidetracked by some calls for a bit. |
|
Hopefully #10870 should fix the linting issues |
|
I merged that fix. Can you rebase this to pull in those changes? |
* Introduce tests for add new visualization link * address code review comment
stacey-gammon
force-pushed
the
add-vis-tests
branch
from
e19a8d7 to
8e379d4
Compare
|
I think this job just got caught up in the jenkins maintenance window. |
|
jenkins, test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #10785