[lint] Fix no-undef errors #10859
Merged
[lint] Fix no-undef errors #10859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjoar
approved these changes
Mar 22, 2017
|
Is this okay to backport? I'm getting these errors on 5.x |
elastic-jasper
added a commit
that referenced
this pull request
Mar 23, 2017
Backports PR #10859 **Commit 1:** [lint] Fix no-undef errors * Original sha: 64e8f50 * Authored by Jonathan Budzenski <[email protected]> on 2017-03-22T22:09:12Z
|
I kicked off a backport of this: #10868 @stacey-gammon Especially if jenkins is failing, feel free to do whatever you think is necessary to get it running successfully again. If for some reason this wasn't OK to backport, it either wouldn't fix the problem (which a backport PR would tell us) or we could revert the backport and figure out why it fixed the problem but was simultaneously not OK to backport :) |
|
Thanks @epixa, I was very close to backporting myself, but hesitated. Next time I'll charge ahead. :) |
epixa
pushed a commit
that referenced
this pull request
Mar 23, 2017
Backports PR #10859 **Commit 1:** [lint] Fix no-undef errors * Original sha: 64e8f50 * Authored by Jonathan Budzenski <[email protected]> on 2017-03-22T22:09:12Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was from #10708, it didn't have the new lint rules.