Update Analytics overview page to new empty state template #108532

ryankeairns · 2021-08-13T13:24:50Z

Relates to #107682

Summary

Replaces current Analytics empty state design with new version provided by KibanaPageTemplate
Removes files for old Analytics empty state view (getting_started)

Screenshot of Analytics overview empty state page

Note: the 'learn more' is pointing to https://www.elastic.co/guide/en/kibana/{VERSION}/index.html

Checklist

Delete any items that are not applicable to this PR.
Covered by template PR

cc:/ @alexfrancoeur @VijayDoshi

cchaos

Design changes LGTM. The view of this page is still dependent on fixing the logic based on the pre-installed beats/index-patterns (#108294). I tested this PR by manually deleting those pre-installed index-patterns.

src/plugins/kibana_overview/public/components/overview/overview.tsx

lukeelmers

Overall LGTM, just had a nit, a question, and a favor 🙂

lukeelmers · 2021-08-13T18:52:26Z

src/plugins/kibana_overview/public/components/overview/overview.tsx

+        href: addBasePath(`home#/tutorial_directory`),
+      },
+    },
+    docsLink: 'https://www.elastic.co/kibana/',


I know it's an extra step, but could we add this product page URL to the core docLinks service and import it from there instead?

We've done something similar for elastic.co/maps:

kibana/src/core/public/doc_links/doc_links_service.ts

Line 267 in 8088565

maps: `${ELASTIC_WEBSITE_URL}maps`,

Switched to a docs link (instead of the previous product link). This also meant returning the KIBANA_DOCS url since it points to the current version of the docs versus the other kibana links value that drops you on the full list of versions, which seems not very helpful.

Switched to a docs link (instead of the previous product link)

Ah, so if you want to use the docs link instead, then I don't think you'll need to change anything in the docLinks service itself, as this is already exposed under links.kibana:

kibana/src/core/public/doc_links/doc_links_service.ts

Line 147 in fa99b8e

kibana: `${KIBANA_DOCS}index.html`,

I think you would only need to update the service if you wanted to use the product link.

In the PR summary, it states that we want the learn more link to go to https://www.elastic.co/kibana/, so it's now using ${ELASTIC_WEBSITE_URL}kibana.

This was my original guess not seeing guidance from Kibana Product, and then I thought docs might be better and aligned with what Obs is doing. @alexfrancoeur which of these do you prefer for the 'learn more' link?

https://www.elastic.co/kibana/ or

https://elastic.co/guide/en/kibana/{CURRENT_VERSION}/

Apologies if I missed this being answered elsewhere.

Discussed with Alex and we'd like to align with what other solutions are doing as we also feel the docs information is a better fit at this point in the experience. Security and Observability are also pointing the guide/docs.

src/plugins/kibana_overview/public/components/overview/overview.tsx

cchaos · 2021-08-14T15:51:47Z

@elasticmachine merge upstream

Use exisiting docLinks.ELASTIC_WEBSITE_URL instead

lukeelmers

LGTM! Thanks for looking at the docLinks feedback.

alexfrancoeur · 2021-08-16T13:17:04Z

I haven't pulled the PR yet, so not sure if this is the latest but had a few quick questions. We'll want to make sure @AlonaNadler provides some input as well.

Product wise, do we want to be calling this page "Elastic Analytics" or just "Analytics"?

Second, the CTA is for beats but really where they're going includes beats tutorials, a link out to the integrations page, file upload and sample data. Is it possible to simplify and just say "Add Data"?

I don't think we need answers before FF, and can always adjust text before the 7.15 public release, but it'd be good to align on how we want to talk about this grouping of apps in Kibana.

ryankeairns · 2021-08-16T14:38:35Z

Amended that last commit to remove the additions to the doc links service (🎩 Caroline). I was misinterpreting the value of the links.kibana URL which turned out to be doing what I was actually after.

gchaps · 2021-08-16T19:20:58Z

I made comments in this issue re: copy.

ryankeairns · 2021-08-16T19:26:21Z

I made comments in this issue re: copy.

Thanks Gail. Those are defined in the underlying template, so they should appear here once changed at that level.

kibanamachine · 2021-08-16T19:53:27Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`kibanaOverview`	33	31	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`kibanaOverview`	21.5KB	18.3KB	-3.2KB

History

💔 Build #145735 failed 3b55390
💔 Build #145705 failed ef0dc765a59a7749c0b7a811c29c59dbf9f8e01f
💚 Build #145498 succeeded 1fb3d19
💔 Build #145490 failed 2be8176
💔 Build #145420 failed fa99b8e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…08532) * Use empty state page template * Remove unused translations * Fixed snaps * Use docLinks service * Fix test * Revert "Use docLinks service" Use exisiting docLinks.ELASTIC_WEBSITE_URL instead * Update learn more link and test * fix test Co-authored-by: cchaos <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-08-16T19:56:56Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…108773) * Use empty state page template * Remove unused translations * Fixed snaps * Use docLinks service * Fix test * Revert "Use docLinks service" Use exisiting docLinks.ELASTIC_WEBSITE_URL instead * Update learn more link and test * fix test Co-authored-by: cchaos <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ryan Keairns <[email protected]> Co-authored-by: cchaos <[email protected]>

Use empty state page template

225b7ff

ryankeairns requested a review from a team as a code owner August 13, 2021 13:24

ryankeairns requested a review from cchaos August 13, 2021 13:25

ryankeairns added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0 labels Aug 13, 2021

ryankeairns and others added 2 commits August 13, 2021 08:51

Remove unused translations

a7dcc53

Fixed snaps

fb1f470

cchaos approved these changes Aug 13, 2021

View reviewed changes

src/plugins/kibana_overview/public/components/overview/overview.tsx Outdated Show resolved Hide resolved

lukeelmers reviewed Aug 13, 2021

View reviewed changes

Use docLinks service

fa99b8e

kibanamachine and others added 3 commits August 14, 2021 11:51

Merge branch 'master' into rk/analytics-empty-state

7179f5a

Fix test

2be8176

Revert "Use docLinks service"

1fb3d19

Use exisiting docLinks.ELASTIC_WEBSITE_URL instead

ryankeairns requested a review from lukeelmers August 15, 2021 20:33

lukeelmers approved these changes Aug 15, 2021

View reviewed changes

Update learn more link and test

3b55390

ryankeairns force-pushed the rk/analytics-empty-state branch from ef0dc76 to 3b55390 Compare August 16, 2021 14:36

fix test

02f80c1

ryankeairns merged commit 36bba6f into elastic:master Aug 16, 2021

kibanamachine mentioned this pull request Aug 16, 2021

[7.x] Update Analytics overview page to new empty state template (#108532) #108773

Merged

cchaos mentioned this pull request Aug 17, 2021

Empty state suggestions for ingest #107682

Closed

12 tasks

This was referenced Sep 3, 2021

[Index Pattern Management] Show empty prompts in the page contents and don't auto-open flyout #109523

Closed

[META] [Kibana Analytics] Show consistent empty state when no data #111184

Open

ryankeairns mentioned this pull request Sep 14, 2021

Create a common no-data view and conditional check for Analytics applications #112109

Closed

pgayvallet mentioned this pull request Nov 12, 2021

Data upload and Add data link under Analytics Tab is inconsistent. #116411

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Analytics overview page to new empty state template #108532

Update Analytics overview page to new empty state template #108532

ryankeairns commented Aug 13, 2021 •

edited

Loading

cchaos left a comment

lukeelmers left a comment

lukeelmers Aug 13, 2021

ryankeairns Aug 13, 2021

lukeelmers Aug 14, 2021

cchaos Aug 14, 2021

ryankeairns Aug 15, 2021 •

edited

Loading

ryankeairns Aug 16, 2021

cchaos commented Aug 14, 2021

lukeelmers left a comment

alexfrancoeur commented Aug 16, 2021

ryankeairns commented Aug 16, 2021

gchaps commented Aug 16, 2021

ryankeairns commented Aug 16, 2021

kibanamachine commented Aug 16, 2021

kibanamachine commented Aug 16, 2021

Update Analytics overview page to new empty state template #108532

Update Analytics overview page to new empty state template #108532

Conversation

ryankeairns commented Aug 13, 2021 • edited Loading

Summary

Screenshot of Analytics overview empty state page

Checklist

cchaos left a comment

Choose a reason for hiding this comment

lukeelmers left a comment

Choose a reason for hiding this comment

lukeelmers Aug 13, 2021

Choose a reason for hiding this comment

ryankeairns Aug 13, 2021

Choose a reason for hiding this comment

lukeelmers Aug 14, 2021

Choose a reason for hiding this comment

cchaos Aug 14, 2021

Choose a reason for hiding this comment

ryankeairns Aug 15, 2021 • edited Loading

Choose a reason for hiding this comment

ryankeairns Aug 16, 2021

Choose a reason for hiding this comment

cchaos commented Aug 14, 2021

lukeelmers left a comment

Choose a reason for hiding this comment

alexfrancoeur commented Aug 16, 2021

ryankeairns commented Aug 16, 2021

gchaps commented Aug 16, 2021

ryankeairns commented Aug 16, 2021

kibanamachine commented Aug 16, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Aug 16, 2021

💚 Backport successful

ryankeairns commented Aug 13, 2021 •

edited

Loading

ryankeairns Aug 15, 2021 •

edited

Loading