-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solutions][Detection Engine] Uses the transient for the styled component to remove React stack traces #108435
Merged
FrankHassanabad
merged 1 commit into
elastic:master
from
FrankHassanabad:fix-test-error
Aug 12, 2021
Merged
[Security Solutions][Detection Engine] Uses the transient for the styled component to remove React stack traces #108435
FrankHassanabad
merged 1 commit into
elastic:master
from
FrankHassanabad:fix-test-error
Aug 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankHassanabad
added
Feature:Detection Alerts
Security Solution Detection Alerts Feature
v8.0.0
v7.15.0
Team:Detections and Resp
Security Detection Response Team
release_note:skip
Skip the PR/issue when compiling release notes
labels
Aug 12, 2021
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
dplumlee
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🦖 🏎️
FrankHassanabad
added
the
auto-backport
Deprecated - use backport:version if exact versions are needed
label
Aug 12, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 12, 2021
…es (elastic#108435) ## Summary When running the tests for detections like so: ```sh node scripts/jest.js x-pack/plugins/security_solution/public/detections ``` We see two stack traces come up: ```sh PASS x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.test.tsx (51.663 s) ● Console console.error Warning: React does not recognize the `isActive` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isactive` instead. If you accidentally passed it from a parent component, remove it from the DOM element. in button (created by EuiButtonEmpty) in EuiButtonEmpty (created by EuiFilterButton) in EuiFilterButton (created by Styled(EuiFilterButton)) in Styled(EuiFilterButton) (created by AlertsTableFilterGroupComponent) in div (created by EuiFilterGroup) in EuiFilterGroup (created by Styled(EuiFilterGroup)) in Styled(EuiFilterGroup) (created by AlertsTableFilterGroupComponent) in AlertsTableFilterGroupComponent (created by DetectionEnginePageComponent) in div (created by Display) in Display (created by DetectionEnginePageComponent) in div (created by Wrapper) in Wrapper (created by SecuritySolutionPageWrapperComponent) in SecuritySolutionPageWrapperComponent (created by DetectionEnginePageComponent) in div (created by styled.div) in styled.div (created by DetectionEnginePageComponent) in DetectionEnginePageComponent (created by ConnectFunction) in ConnectFunction in Router in Provider (created by App) in App (created by ErrorBoundary) in ErrorBoundary (created by DragDropContext) in DragDropContext (created by TestProvidersComponent) in ThemeProvider (created by TestProvidersComponent) in Provider (created by TestProvidersComponent) in Provider in Unknown (created by TestProvidersComponent) in PseudoLocaleWrapper (created by I18nProvider) in IntlProvider (created by I18nProvider) in I18nProvider (created by TestProvidersComponent) in TestProvidersComponent (created by WrapperComponent) in WrapperComponent at warningWithoutStack (node_modules/react-dom/cjs/react-dom.development.js:530:32) at warning (node_modules/react-dom/cjs/react-dom.development.js:1018:27) at validateProperty$1 (node_modules/react-dom/cjs/react-dom.development.js:7462:7) at warnUnknownProperties (node_modules/react-dom/cjs/react-dom.development.js:7505:19) at validateProperties$2 (node_modules/react-dom/cjs/react-dom.development.js:7528:3) at validatePropertiesInDevelopment (node_modules/react-dom/cjs/react-dom.development.js:7575:5) at setInitialProperties (node_modules/react-dom/cjs/react-dom.development.js:7860:5) PASS x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/details/index.test.tsx (54.841 s) ● Console console.error Warning: React does not recognize the `isActive` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isactive` instead. If you accidentally passed it from a parent component, remove it from the DOM element. in button (created by EuiButtonEmpty) in EuiButtonEmpty (created by EuiFilterButton) in EuiFilterButton (created by Styled(EuiFilterButton)) in Styled(EuiFilterButton) (created by AlertsTableFilterGroupComponent) in div (created by EuiFilterGroup) in EuiFilterGroup (created by Styled(EuiFilterGroup)) in Styled(EuiFilterGroup) (created by AlertsTableFilterGroupComponent) in AlertsTableFilterGroupComponent (created by RuleDetailsPageComponent) in div (created by Wrapper) in Wrapper (created by SecuritySolutionPageWrapperComponent) in SecuritySolutionPageWrapperComponent (created by RuleDetailsPageComponent) in div (created by styled.div) in styled.div (created by RuleDetailsPageComponent) in RuleDetailsPageComponent (created by ConnectFunction) in ConnectFunction in Router in Provider (created by App) in App (created by ErrorBoundary) in ErrorBoundary (created by DragDropContext) in DragDropContext (created by TestProvidersComponent) in ThemeProvider (created by TestProvidersComponent) in Provider (created by TestProvidersComponent) in Provider in Unknown (created by TestProvidersComponent) in PseudoLocaleWrapper (created by I18nProvider) in IntlProvider (created by I18nProvider) in I18nProvider (created by TestProvidersComponent) in TestProvidersComponent (created by WrapperComponent) in WrapperComponent at warningWithoutStack (node_modules/react-dom/cjs/react-dom.development.js:530:32) at warning (node_modules/react-dom/cjs/react-dom.development.js:1018:27) at validateProperty$1 (node_modules/react-dom/cjs/react-dom.development.js:7462:7) at warnUnknownProperties (node_modules/react-dom/cjs/react-dom.development.js:7505:19) at validateProperties$2 (node_modules/react-dom/cjs/react-dom.development.js:7528:3) at validatePropertiesInDevelopment (node_modules/react-dom/cjs/react-dom.development.js:7575:5) at setInitialProperties (node_modules/react-dom/cjs/react-dom.development.js:7860:5) at finalizeInitialChildren (node_modules/react-dom/cjs/react-dom.development.js:9478:3) ``` This is because it looks like we should be using transient variables for styled per [here](https://styled-components.com/docs/api#transient-props) This was introduced from this [PR](elastic#107249) ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 12, 2021
…es (#108435) (#108455) ## Summary When running the tests for detections like so: ```sh node scripts/jest.js x-pack/plugins/security_solution/public/detections ``` We see two stack traces come up: ```sh PASS x-pack/plugins/security_solution/public/detections/pages/detection_engine/detection_engine.test.tsx (51.663 s) ● Console console.error Warning: React does not recognize the `isActive` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isactive` instead. If you accidentally passed it from a parent component, remove it from the DOM element. in button (created by EuiButtonEmpty) in EuiButtonEmpty (created by EuiFilterButton) in EuiFilterButton (created by Styled(EuiFilterButton)) in Styled(EuiFilterButton) (created by AlertsTableFilterGroupComponent) in div (created by EuiFilterGroup) in EuiFilterGroup (created by Styled(EuiFilterGroup)) in Styled(EuiFilterGroup) (created by AlertsTableFilterGroupComponent) in AlertsTableFilterGroupComponent (created by DetectionEnginePageComponent) in div (created by Display) in Display (created by DetectionEnginePageComponent) in div (created by Wrapper) in Wrapper (created by SecuritySolutionPageWrapperComponent) in SecuritySolutionPageWrapperComponent (created by DetectionEnginePageComponent) in div (created by styled.div) in styled.div (created by DetectionEnginePageComponent) in DetectionEnginePageComponent (created by ConnectFunction) in ConnectFunction in Router in Provider (created by App) in App (created by ErrorBoundary) in ErrorBoundary (created by DragDropContext) in DragDropContext (created by TestProvidersComponent) in ThemeProvider (created by TestProvidersComponent) in Provider (created by TestProvidersComponent) in Provider in Unknown (created by TestProvidersComponent) in PseudoLocaleWrapper (created by I18nProvider) in IntlProvider (created by I18nProvider) in I18nProvider (created by TestProvidersComponent) in TestProvidersComponent (created by WrapperComponent) in WrapperComponent at warningWithoutStack (node_modules/react-dom/cjs/react-dom.development.js:530:32) at warning (node_modules/react-dom/cjs/react-dom.development.js:1018:27) at validateProperty$1 (node_modules/react-dom/cjs/react-dom.development.js:7462:7) at warnUnknownProperties (node_modules/react-dom/cjs/react-dom.development.js:7505:19) at validateProperties$2 (node_modules/react-dom/cjs/react-dom.development.js:7528:3) at validatePropertiesInDevelopment (node_modules/react-dom/cjs/react-dom.development.js:7575:5) at setInitialProperties (node_modules/react-dom/cjs/react-dom.development.js:7860:5) PASS x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/details/index.test.tsx (54.841 s) ● Console console.error Warning: React does not recognize the `isActive` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `isactive` instead. If you accidentally passed it from a parent component, remove it from the DOM element. in button (created by EuiButtonEmpty) in EuiButtonEmpty (created by EuiFilterButton) in EuiFilterButton (created by Styled(EuiFilterButton)) in Styled(EuiFilterButton) (created by AlertsTableFilterGroupComponent) in div (created by EuiFilterGroup) in EuiFilterGroup (created by Styled(EuiFilterGroup)) in Styled(EuiFilterGroup) (created by AlertsTableFilterGroupComponent) in AlertsTableFilterGroupComponent (created by RuleDetailsPageComponent) in div (created by Wrapper) in Wrapper (created by SecuritySolutionPageWrapperComponent) in SecuritySolutionPageWrapperComponent (created by RuleDetailsPageComponent) in div (created by styled.div) in styled.div (created by RuleDetailsPageComponent) in RuleDetailsPageComponent (created by ConnectFunction) in ConnectFunction in Router in Provider (created by App) in App (created by ErrorBoundary) in ErrorBoundary (created by DragDropContext) in DragDropContext (created by TestProvidersComponent) in ThemeProvider (created by TestProvidersComponent) in Provider (created by TestProvidersComponent) in Provider in Unknown (created by TestProvidersComponent) in PseudoLocaleWrapper (created by I18nProvider) in IntlProvider (created by I18nProvider) in I18nProvider (created by TestProvidersComponent) in TestProvidersComponent (created by WrapperComponent) in WrapperComponent at warningWithoutStack (node_modules/react-dom/cjs/react-dom.development.js:530:32) at warning (node_modules/react-dom/cjs/react-dom.development.js:1018:27) at validateProperty$1 (node_modules/react-dom/cjs/react-dom.development.js:7462:7) at warnUnknownProperties (node_modules/react-dom/cjs/react-dom.development.js:7505:19) at validateProperties$2 (node_modules/react-dom/cjs/react-dom.development.js:7528:3) at validatePropertiesInDevelopment (node_modules/react-dom/cjs/react-dom.development.js:7575:5) at setInitialProperties (node_modules/react-dom/cjs/react-dom.development.js:7860:5) at finalizeInitialChildren (node_modules/react-dom/cjs/react-dom.development.js:9478:3) ``` This is because it looks like we should be using transient variables for styled per [here](https://styled-components.com/docs/api#transient-props) This was introduced from this [PR](#107249) ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Frank Hassanabad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Detection Alerts
Security Solution Detection Alerts Feature
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detections and Resp
Security Detection Response Team
v7.15.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running the tests for detections like so:
We see two stack traces come up:
This is because it looks like we should be using transient variables for styled per here
This was introduced from this PR
Checklist