Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics: replace deprecated EuiCodeEditor #108306

Merged
merged 3 commits into from
Aug 16, 2021
Merged

[ML] Data Frame Analytics: replace deprecated EuiCodeEditor #108306

merged 3 commits into from
Aug 16, 2021

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 11, 2021 •
edited
Loading

Summary

Related meta issue #107082

This PR replaces the deprecated EuiCodeEditor component in

  • public/application/data_frame_analytics/pages/analytics_creation/components/create_analytics_advanced_editor/create_analytics_advanced_editor.tsx
  • public/application/data_frame_analytics/pages/analytics_creation/components/runtime_mappings/runtime_mappings_editor.tsx
  • public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/expanded_row_json_pane.tsx

Checklist

Delete any items that are not applicable to this PR.

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 11, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner August 11, 2021 23:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 added the release_note:skip Skip the PR/issue when compiling release notes label Aug 11, 2021
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 11, 2021
Closed
12 tasks
peteharverson
peteharverson approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Member

qn895 commented Aug 12, 2021

Code LGTM

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-replace-deprecated-code-editor branch from 0bad259 to 9c4d644 Compare August 12, 2021 17:07
walterra
walterra approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

peteharverson
peteharverson reviewed Aug 13, 2021
View reviewed changes
...me_analytics/pages/analytics_management/components/analytics_list/expanded_row_json_pane.tsx
value={JSON.stringify(json, null, 2)}
readOnly={true}
mode="json"
<EuiCodeBlock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth adding an aria-label for this, something like JSON of data frame analytics configuration

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-replace-deprecated-code-editor branch from 2d0436c to f89b1e8 Compare August 16, 2021 16:41
@alvarezmelissa87 alvarezmelissa87 merged commit c8ddf94 into elastic:master Aug 16, 2021
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 16, 2021
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-replace-deprecated-code-editor branch August 16, 2021 22:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.0MB 6.0MB +354.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

alvarezmelissa87 added a commit that referenced this pull request Aug 17, 2021
@alvarezmelissa87
[ML] Data Frame Analytics: replace deprecated EuiCodeEditor (#108306) (…
e7f3201 
…#108801)

* switch dfa create, runtime, and expanded row json editor to new codeEditor

* add aria label. wrap codeEditor in div to allow data attribute for test

* update functional test service for new code editor
@peteharverson peteharverson mentioned this pull request Oct 12, 2021
Open
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 qn895 approved these changes

@walterra walterra walterra approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alvarezmelissa87 @elasticmachine @qn895 @kibanamachine @walterra @peteharverson