Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ability to disable alerting, actions, task manager, stack alerts, and event log plugins #108281

Merged

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Aug 11, 2021

Resolves #108396

Docs: https://kibana_108281.docs-preview.app.elstc.co/guide/en/kibana/master/alert-action-settings-kb.html

This PR deprecates the ability to disable alerting, actions, task manager, and event log plugins with the plan to remove this config in 8.0.

@chrisronline chrisronline changed the title Alerting/enabled deprecations Deprecate ability to disable alerting, actions, task manager, and event log plugins Aug 12, 2021
@chrisronline chrisronline marked this pull request as ready for review August 12, 2021 15:57
@chrisronline chrisronline requested a review from a team as a code owner August 12, 2021 15:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@chrisronline chrisronline changed the title Deprecate ability to disable alerting, actions, task manager, and event log plugins Deprecate ability to disable alerting, actions, task manager, stack alerts, and event log plugins Aug 12, 2021
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we have the similar tests for stack alerts, alerting and actions as we do in task manager?

@ymao1
Copy link
Contributor

ymao1 commented Aug 12, 2021

Do we need to add this to the triggers_actions_ui plugin as well?

Can we add a deprecation message to the docs? https://www.elastic.co/guide/en/kibana/master/alert-action-settings-kb.html#action-settings

@chrisronline
Copy link
Contributor Author

@ymao1 @YulNaumenko Updated!

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

chrisronline added a commit to chrisronline/kibana that referenced this pull request Aug 13, 2021
…lerts, and event log plugins (elastic#108281)

* Add deprecation warnings for .enabled config for all our plugins

* Add tests

* Add stackAlerts

* Fix stack alerts

* Add tests

* Add triggers_action_ui

* Add deprecated warning to the docs
chrisronline added a commit that referenced this pull request Aug 13, 2021
…lerts, and event log plugins (#108281) (#108470)

* Add deprecation warnings for .enabled config for all our plugins

* Add tests

* Add stackAlerts

* Fix stack alerts

* Add tests

* Add triggers_action_ui

* Add deprecated warning to the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[7.x] Deprecate ability to disable alerting, actions, task manager, stack alerts, and event log plugins
5 participants