[TGrid] Alerts status update use RBAC api #108092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
changed the title
52 tasks
48 tasks
…s and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals
… to use WORKFLOW_STATUS instead of ALERT_STATUS
…dtion to KQL string
adds replace ALERT_STATUS with ALERT_WORKFLOW_STATUS and updates tests and adds logic for switching between signal.status and workflow status when updating alerts in .siem-signals
…us' and not { signals: {status }} in alerts client
optionally use fields api in requests if _source does not contain authz properties
…emd/kibana into tgrid-bulk-actions-rbac-update
semd
changed the title
semd
added
v7.15.0
v8.0.0
release_note:skip
x-pack/test/functional/es_archives/rule_registry/alerts/data.json
Outdated
Show resolved
Hide resolved
x-pack/test/rule_registry/security_and_spaces/tests/basic/bulk_update_alerts.ts
Show resolved
Hide resolved
| @@ -27,7 +27,7 @@ export const AlertConsumers = { | |||
| SYNTHETICS: 'synthetics', | |||
| } as const; | |||
| export type AlertConsumers = typeof AlertConsumers[keyof typeof AlertConsumers]; | |||
| export type STATUS_VALUES = 'open' | 'acknowledged' | 'closed'; | |||
| export type STATUS_VALUES = 'open' | 'acknowledged' | 'closed' | 'in-progress'; // TODO: remove 'in-progress' after migration to 'acknowledged' | |||
There was a problem hiding this comment.
@dplumlee - just pinging you here since you're working on these changes
x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
Outdated
Show resolved
Hide resolved
| return buildEsQuery( | ||
| let esQuery; | ||
| if (id != null) { | ||
| esQuery = { query: `_id:${id}`, language: 'kuery' }; |
There was a problem hiding this comment.
It could be helpful to have a comment here describing how these different scenarios happen
x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
Outdated
Show resolved
Hide resolved
| status: t.union([ | ||
| t.literal('open'), | ||
| t.literal('closed'), | ||
| t.literal('in-progress'), // TODO: remove after migration to acknowledged |
| status: t.union([ | ||
| t.literal('open'), | ||
| t.literal('closed'), | ||
| t.literal('in-progress'), // TODO: remove after migration to acknowledged |
x-pack/plugins/timelines/public/components/t_grid/standalone/index.tsx
Outdated
Show resolved
Hide resolved
|
FWIW I've been attempting to do some type safe "workflow_status" migration updates in an existing PR that I'm hoping to get in today before I leave. |
…test fix a bug where we were not waiting for updates to complete when usin…
3 tasks
michaelolo24
approved these changes
Aug 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 14, 2021
Co-authored-by: Devin Hurley <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 14, 2021
Co-authored-by: Devin Hurley <[email protected]> Co-authored-by: Sergi Massaneda <[email protected]> Co-authored-by: Devin Hurley <[email protected]>
asnehalb
changed the title
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @dhurley14 @semd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Call RBAC alerts bulk update endpoint from the tGrid status bulk update. It is used in 3 different places:
Bulk status update
Single status update from table row
SIngle status update from flyout
ℹ️- Currently allowing both
in-progressandacknowledgedstatus. Thein-progressstatus will need to be cleaned in the status field migration.Checklist
Delete any items that are not applicable to this PR.