-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAC] [RBAC] working find route for alerts as data client #107982
Merged
Merged
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3c18dba
working find route
dhurley14 ba914ec
adds types find to prevent usage of aggs except for metrics and bucke…
dhurley14 7808549
Merge branch 'master' into alerts_client_find_api
dhurley14 a435c70
adds jest tests, partially working integration tests, unauthorized te…
dhurley14 d6fa4e2
fixes integration tests for find api
dhurley14 68d0f41
updates alerts count panel UI to use rule registry alerts as data fin…
dhurley14 50200d1
Merge remote-tracking branch 'upstream/master' into alerts_client_fin…
dhurley14 6d826b3
fix some newly renamed things after merge with master
dhurley14 ff5226e
Merge remote-tracking branch 'upstream/master' into alerts_client_fin…
dhurley14 de44247
do not 404 when there are empty hits, just return empty hits, fixes a…
dhurley14 e69493d
Merge remote-tracking branch 'upstream/master' into alerts_client_fin…
dhurley14 21f27f6
update histograms on overview page
dhurley14 e00a071
little cleanup
dhurley14 85ea8ed
remove logs and undo unnecessary changes in timeline
dhurley14 a442929
fix describe in the integration test
dhurley14 3976697
fixes integration test, alerting authorization filter will return emp…
dhurley14 9596697
fix merge conflicts after merge with master
dhurley14 e08c2cd
fix other failing integration tests
dhurley14 42f5a94
remove commented out code
dhurley14 4d89998
updates alerts client docs
dhurley14 628cd86
merge with master
dhurley14 862b5ad
allow nested aggs but disallow scripts fields and other extraneous fi…
dhurley14 a8188db
fixes bug where date_histogram was disallowed, removes ts-expect-erro…
dhurley14 5de23b5
removes debug log, removes unnecessary ts expect error, fixes bug whe…
dhurley14 4602b35
adds integration test for histogram query on rule details page
dhurley14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be deleted,
estypes.IndicesPutIndexTemplateRequest
containscomposed_of
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good catch. I copied some of these types from elsewhere in kibana so didn't look too deeply at the types but I will update this. Thanks!